Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698791 > unrolled thread

[net-next PATCH] IB/hns: include linux/interrupt.h

Back to article view | Back to linux.kernel

Contents

  [net-next PATCH] IB/hns: include linux/interrupt.h Arnd Bergmann <arnd@arndb.de> - 2017-07-28 15:40 +0200
    Re: [net-next PATCH] IB/hns: include linux/interrupt.h Doug Ledford <dledford@redhat.com> - 2017-07-31 20:50 +0200

#1698791 — [net-next PATCH] IB/hns: include linux/interrupt.h

I ran into this build error on linux-next:

drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type name 'irqreturn_t'
 static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr)
        ^~~~~~~~~~~
drivers/infiniband/hw/hns/hns_roce_eq.c: In function 'hns_roce_msi_x_interrupt':
drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [-Werror=implicit-function-declaration]
  return IRQ_RETVAL(int_work);

I have bisected this to a seemingly unrelated change that happened
to remove some indirect header inclusions. Simply including the
required header explicitly fixes the build failure.

Fixes: 09c7570480f7 ("xfrm: remove flow cache")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/infiniband/hw/hns/hns_roce_eq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c b/drivers/infiniband/hw/hns/hns_roce_eq.c
index 50f864935a0e..b39d14b62355 100644
--- a/drivers/infiniband/hw/hns/hns_roce_eq.c
+++ b/drivers/infiniband/hw/hns/hns_roce_eq.c
@@ -31,6 +31,7 @@
  */
 
 #include <linux/platform_device.h>
+#include <linux/interrupt.h>
 #include "hns_roce_common.h"
 #include "hns_roce_device.h"
 #include "hns_roce_eq.h"
-- 
2.9.0

[toc] | [next] | [standalone]

#1700316

On Fri, 2017-07-28 at 15:35 +0200, Arnd Bergmann wrote:
> I ran into this build error on linux-next:
> 
> drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type
> name 'irqreturn_t'
>  static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr)
>         ^~~~~~~~~~~
> drivers/infiniband/hw/hns/hns_roce_eq.c: In function
> 'hns_roce_msi_x_interrupt':
> drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit
> declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [-
> Werror=implicit-function-declaration]
>   return IRQ_RETVAL(int_work);
> 
> I have bisected this to a seemingly unrelated change that happened
> to remove some indirect header inclusions. Simply including the
> required header explicitly fixes the build failure.
> 
> Fixes: 09c7570480f7 ("xfrm: remove flow cache")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web