Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1700316

Re: [net-next PATCH] IB/hns: include linux/interrupt.h

From Doug Ledford <dledford@redhat.com>
Newsgroups linux.kernel
Subject Re: [net-next PATCH] IB/hns: include linux/interrupt.h
Date 2017-07-31 20:50 +0200
Message-ID <u9nVo-1jR-17@gated-at.bofh.it> (permalink)
References <u8dEJ-4kJ-7@gated-at.bofh.it>
Organization Red Hat, Inc.

Show all headers | View raw


On Fri, 2017-07-28 at 15:35 +0200, Arnd Bergmann wrote:
> I ran into this build error on linux-next:
> 
> drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type
> name 'irqreturn_t'
>  static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr)
>         ^~~~~~~~~~~
> drivers/infiniband/hw/hns/hns_roce_eq.c: In function
> 'hns_roce_msi_x_interrupt':
> drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit
> declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [-
> Werror=implicit-function-declaration]
>   return IRQ_RETVAL(int_work);
> 
> I have bisected this to a seemingly unrelated change that happened
> to remove some indirect header inclusions. Simply including the
> required header explicitly fixes the build failure.
> 
> Fixes: 09c7570480f7 ("xfrm: remove flow cache")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[net-next PATCH] IB/hns: include linux/interrupt.h Arnd Bergmann <arnd@arndb.de> - 2017-07-28 15:40 +0200
  Re: [net-next PATCH] IB/hns: include linux/interrupt.h Doug Ledford <dledford@redhat.com> - 2017-07-31 20:50 +0200

csiph-web