Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692799 > unrolled thread

[PATCH 0/4] Drop uninformative messages from bootlog

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/4] Drop uninformative messages from bootlog Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 13:10 +0200
    [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 13:10 +0200
      Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Jassi Brar <jassisinghbrar@gmail.com> - 2017-07-31 18:50 +0200
      Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Alexey Klimov <alexey.klimov@arm.com> - 2017-07-31 19:50 +0200
        Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> - 2017-08-01 00:30 +0200
          Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-08-01 11:00 +0200
    [PATCH 4/4] xen: Drop un-informative message during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 13:10 +0200
      Re: [PATCH 4/4] xen: Drop un-informative message during boot Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-07-20 23:30 +0200
        Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-21 12:20 +0200
          Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during  boot Juergen Gross <jgross@suse.com> - 2017-07-21 12:20 +0200
            Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-21 12:30 +0200
      Re: [PATCH 4/4] xen: Drop un-informative message during boot Juergen Gross <jgross@suse.com> - 2017-07-28 11:40 +0200

#1692799 — [PATCH 0/4] Drop uninformative messages from bootlog

Hi,

While booting v4.13-rc1 on an arm64 system, I noticed some messages
that clutter the boot log without providing any useful
information. This series trims some of the obvious offenders.

The patches are spread across a few sub-systems - arm64/mm, mailbox,
APEI and xen, and can be independently merged.

Thanks,
Punit


Punit Agrawal (4):
  arm64/numa: Drop duplicate message
  mailbox: pcc: Drop uninformative output during boot
  ACPI / APEI: Drop uninformative messages during boot
  xen: Drop un-informative message during boot

 arch/arm64/mm/numa.c      | 7 +------
 drivers/acpi/apei/ghes.c  | 9 +--------
 drivers/mailbox/pcc.c     | 4 +---
 drivers/xen/xenfs/super.c | 1 -
 4 files changed, 3 insertions(+), 18 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1692805 — [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

When booting on an ACPI enabled system that does not provide the
Platform Communications Channel Table (PCCT), the pcc mailbox driver
prints -

[    0.484261] PCCT header not found.

during probe before returning -ENODEV.

This message clutters the bootlog and doesn't provide any useful
information. Drop this message.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>
---
 drivers/mailbox/pcc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index ac91fd0d62c6..3d83cdc11ab5 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void)
 	/* Search for PCCT */
 	status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
 
-	if (ACPI_FAILURE(status) || !pcct_tbl) {
-		pr_warn("PCCT header not found.\n");
+	if (ACPI_FAILURE(status) || !pcct_tbl)
 		return -ENODEV;
-	}
 
 	count = acpi_table_parse_entries(ACPI_SIG_PCCT,
 			sizeof(struct acpi_table_pcct),
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1700197 — Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

[CC'ing Rafael J. Wysocki, who picks patches for pcc.c]

On Mon, Jul 31, 2017 at 3:22 PM, Punit Agrawal <punit.agrawal@arm.com> wrote:
> Punit Agrawal <punit.agrawal@arm.com> writes:
>
>> When booting on an ACPI enabled system that does not provide the
>> Platform Communications Channel Table (PCCT), the pcc mailbox driver
>> prints -
>>
>> [    0.484261] PCCT header not found.
>>
>> during probe before returning -ENODEV.
>>
>> This message clutters the bootlog and doesn't provide any useful
>> information. Drop this message.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Jassi Brar <jassisinghbrar@gmail.com>
>> ---
>>  drivers/mailbox/pcc.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
>> index ac91fd0d62c6..3d83cdc11ab5 100644
>> --- a/drivers/mailbox/pcc.c
>> +++ b/drivers/mailbox/pcc.c
>> @@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void)
>>       /* Search for PCCT */
>>       status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
>>
>> -     if (ACPI_FAILURE(status) || !pcct_tbl) {
>> -             pr_warn("PCCT header not found.\n");
>> +     if (ACPI_FAILURE(status) || !pcct_tbl)
>>               return -ENODEV;
>> -     }
>>
>>       count = acpi_table_parse_entries(ACPI_SIG_PCCT,
>>                       sizeof(struct acpi_table_pcct),
>
> Ping! Any comments/concerns with dropping the message?
>
> Thanks.

[toc] | [prev] | [next] | [standalone]

#1700263 — Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

(keeping Rafael in c/c per Jassi suggestion)

On Thu, Jul 20, 2017 at 12:04 PM, Punit Agrawal <punit.agrawal@arm.com> wrote:
> When booting on an ACPI enabled system that does not provide the
> Platform Communications Channel Table (PCCT), the pcc mailbox driver
> prints -
> 
> [    0.484261] PCCT header not found.

Ah. I thought this was already removed ages ago. Thanks for removing this.
 
> during probe before returning -ENODEV.
> 
> This message clutters the bootlog and doesn't provide any useful
> information. Drop this message.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>

Acked-by: Alexey Klimov <alexey.klimov@arm.com>

[toc] | [prev] | [next] | [standalone]

#1700444 — Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

On 7/31/2017 7:47 PM, Alexey Klimov wrote:
> (keeping Rafael in c/c per Jassi suggestion)
>
> On Thu, Jul 20, 2017 at 12:04 PM, Punit Agrawal <punit.agrawal@arm.com> wrote:
>> When booting on an ACPI enabled system that does not provide the
>> Platform Communications Channel Table (PCCT), the pcc mailbox driver
>> prints -
>>
>> [    0.484261] PCCT header not found.
> Ah. I thought this was already removed ages ago. Thanks for removing this.
>   
>> during probe before returning -ENODEV.
>>
>> This message clutters the bootlog and doesn't provide any useful
>> information. Drop this message.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Acked-by: Alexey Klimov <alexey.klimov@arm.com>
>
Please resend this, including all applicable tags, with a CC to 
linux-acpi@vger.kernel.org for easier processing.

Thanks,

Rafael

[toc] | [prev] | [next] | [standalone]

#1700760 — Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

"Rafael J. Wysocki" <rafael.j.wysocki@intel.com> writes:

> On 7/31/2017 7:47 PM, Alexey Klimov wrote:
>> (keeping Rafael in c/c per Jassi suggestion)
>>
>> On Thu, Jul 20, 2017 at 12:04 PM, Punit Agrawal <punit.agrawal@arm.com> wrote:
>>> When booting on an ACPI enabled system that does not provide the
>>> Platform Communications Channel Table (PCCT), the pcc mailbox driver
>>> prints -
>>>
>>> [    0.484261] PCCT header not found.
>> Ah. I thought this was already removed ages ago. Thanks for removing this.
>>   
>>> during probe before returning -ENODEV.
>>>
>>> This message clutters the bootlog and doesn't provide any useful
>>> information. Drop this message.
>>>
>>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>>> Cc: Jassi Brar <jassisinghbrar@gmail.com>
>> Acked-by: Alexey Klimov <alexey.klimov@arm.com>
>>
> Please resend this, including all applicable tags, with a CC to
> linux-acpi@vger.kernel.org for easier processing.

Thanks Jassi for adding the appropriate folks on this
patch. get_maintainer.pl threw me off on this one. ;)

I'll add the tags (Thanks, Alexey) and re-send.

>
> Thanks,
>
> Rafael

[toc] | [prev] | [next] | [standalone]

#1692810 — [PATCH 4/4] xen: Drop un-informative message during boot

On systems that are not booted as a Xen domain, the xenfs driver prints
the following message during boot.

[    3.460595] xenfs: not registering filesystem on non-xen platform

As the user chose not to boot a Xen domain, this message does not
provide useful information. Drop this message.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
---
 drivers/xen/xenfs/super.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/xen/xenfs/super.c b/drivers/xen/xenfs/super.c
index 967f069385d0..71ddfb4cf61c 100644
--- a/drivers/xen/xenfs/super.c
+++ b/drivers/xen/xenfs/super.c
@@ -87,7 +87,6 @@ static int __init xenfs_init(void)
 	if (xen_domain())
 		return register_filesystem(&xenfs_type);
 
-	pr_info("not registering filesystem on non-xen platform\n");
 	return 0;
 }
 
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1693237 — Re: [PATCH 4/4] xen: Drop un-informative message during boot

On 07/20/2017 07:04 AM, Punit Agrawal wrote:
> On systems that are not booted as a Xen domain, the xenfs driver prints
> the following message during boot.
>
> [    3.460595] xenfs: not registering filesystem on non-xen platform
>
> As the user chose not to boot a Xen domain, this message does not
> provide useful information. Drop this message.
>
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

[toc] | [prev] | [next] | [standalone]

#1693560 — Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot

Boris Ostrovsky <boris.ostrovsky@oracle.com> writes:

> On 07/20/2017 07:04 AM, Punit Agrawal wrote:
>> On systems that are not booted as a Xen domain, the xenfs driver prints
>> the following message during boot.
>>
>> [    3.460595] xenfs: not registering filesystem on non-xen platform
>>
>> As the user chose not to boot a Xen domain, this message does not
>> provide useful information. Drop this message.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: Juergen Gross <jgross@suse.com>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Thanks Boris.

Juergen, I assume you'll pick this up for the next round of xen
updates.

>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

[toc] | [prev] | [next] | [standalone]

#1693563 — Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot

On 21/07/17 12:12, Punit Agrawal wrote:
> Boris Ostrovsky <boris.ostrovsky@oracle.com> writes:
> 
>> On 07/20/2017 07:04 AM, Punit Agrawal wrote:
>>> On systems that are not booted as a Xen domain, the xenfs driver prints
>>> the following message during boot.
>>>
>>> [    3.460595] xenfs: not registering filesystem on non-xen platform
>>>
>>> As the user chose not to boot a Xen domain, this message does not
>>> provide useful information. Drop this message.
>>>
>>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>> Cc: Juergen Gross <jgross@suse.com>
>>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
> Thanks Boris.
> 
> Juergen, I assume you'll pick this up for the next round of xen
> updates.

Yes, probably for rc3 or rc4. For rc2 it was a liitle bit late and
there is no need to hurry.


Juergen

[toc] | [prev] | [next] | [standalone]

#1693570 — Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot

Juergen Gross <jgross@suse.com> writes:

> On 21/07/17 12:12, Punit Agrawal wrote:
>> Boris Ostrovsky <boris.ostrovsky@oracle.com> writes:
>> 
>>> On 07/20/2017 07:04 AM, Punit Agrawal wrote:
>>>> On systems that are not booted as a Xen domain, the xenfs driver prints
>>>> the following message during boot.
>>>>
>>>> [    3.460595] xenfs: not registering filesystem on non-xen platform
>>>>
>>>> As the user chose not to boot a Xen domain, this message does not
>>>> provide useful information. Drop this message.
>>>>
>>>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>>>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>>> Cc: Juergen Gross <jgross@suse.com>
>>>
>>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> 
>> Thanks Boris.
>> 
>> Juergen, I assume you'll pick this up for the next round of xen
>> updates.
>
> Yes, probably for rc3 or rc4. For rc2 it was a liitle bit late and
> there is no need to hurry.

Agreed! Thanks for confirming.

[toc] | [prev] | [next] | [standalone]

#1698622 — Re: [PATCH 4/4] xen: Drop un-informative message during boot

On 20/07/17 13:04, Punit Agrawal wrote:
> On systems that are not booted as a Xen domain, the xenfs driver prints
> the following message during boot.
> 
> [    3.460595] xenfs: not registering filesystem on non-xen platform
> 
> As the user chose not to boot a Xen domain, this message does not
> provide useful information. Drop this message.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>

Committed to: xen/tip.git for-linus-4.13b


Thanks,

Juergen

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web