Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

From	Jassi Brar <jassisinghbrar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot
Date	2017-07-31 18:50 +0200
Message-ID	<u9m3f-9W-7@gated-at.bofh.it> (permalink)
References	<u5hvb-6vT-3@gated-at.bofh.it> <u5hve-6vT-31@gated-at.bofh.it> <u9m3f-9W-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[CC'ing Rafael J. Wysocki, who picks patches for pcc.c]

On Mon, Jul 31, 2017 at 3:22 PM, Punit Agrawal <punit.agrawal@arm.com> wrote:
> Punit Agrawal <punit.agrawal@arm.com> writes:
>
>> When booting on an ACPI enabled system that does not provide the
>> Platform Communications Channel Table (PCCT), the pcc mailbox driver
>> prints -
>>
>> [    0.484261] PCCT header not found.
>>
>> during probe before returning -ENODEV.
>>
>> This message clutters the bootlog and doesn't provide any useful
>> information. Drop this message.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Jassi Brar <jassisinghbrar@gmail.com>
>> ---
>>  drivers/mailbox/pcc.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
>> index ac91fd0d62c6..3d83cdc11ab5 100644
>> --- a/drivers/mailbox/pcc.c
>> +++ b/drivers/mailbox/pcc.c
>> @@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void)
>>       /* Search for PCCT */
>>       status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
>>
>> -     if (ACPI_FAILURE(status) || !pcct_tbl) {
>> -             pr_warn("PCCT header not found.\n");
>> +     if (ACPI_FAILURE(status) || !pcct_tbl)
>>               return -ENODEV;
>> -     }
>>
>>       count = acpi_table_parse_entries(ACPI_SIG_PCCT,
>>                       sizeof(struct acpi_table_pcct),
>
> Ping! Any comments/concerns with dropping the message?
>
> Thanks.

Thread

[PATCH 0/4] Drop uninformative messages from bootlog Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 13:10 +0200
  [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 13:10 +0200
    Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Jassi Brar <jassisinghbrar@gmail.com> - 2017-07-31 18:50 +0200
    Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Alexey Klimov <alexey.klimov@arm.com> - 2017-07-31 19:50 +0200
      Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> - 2017-08-01 00:30 +0200
        Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-08-01 11:00 +0200
  [PATCH 4/4] xen: Drop un-informative message during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-20 13:10 +0200
    Re: [PATCH 4/4] xen: Drop un-informative message during boot Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-07-20 23:30 +0200
      Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-21 12:20 +0200
        Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during  boot Juergen Gross <jgross@suse.com> - 2017-07-21 12:20 +0200
          Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot Punit Agrawal <punit.agrawal@arm.com> - 2017-07-21 12:30 +0200
    Re: [PATCH 4/4] xen: Drop un-informative message during boot Juergen Gross <jgross@suse.com> - 2017-07-28 11:40 +0200

csiph-web