Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1699512 > unrolled thread
| Started by | Axel Lin <axel.lin@ingics.com> |
|---|---|
| First post | 2017-07-30 13:00 +0200 |
| Last post | 2017-08-08 12:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Axel Lin <axel.lin@ingics.com> - 2017-07-30 13:00 +0200
Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Keerthy <j-keerthy@ti.com> - 2017-07-31 06:20 +0200
Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:10 +0200
| From | Axel Lin <axel.lin@ingics.com> |
|---|---|
| Date | 2017-07-30 13:00 +0200 |
| Subject | [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices |
| Message-ID | <u8U6Z-7Fp-3@gated-at.bofh.it> |
This fixes missing mfd_remove_devices() call when unload the module.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/lp87565.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
index 340ad0c..32d2a07 100644
--- a/drivers/mfd/lp87565.c
+++ b/drivers/mfd/lp87565.c
@@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
i2c_set_clientdata(client, lp87565);
- ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
- ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
-
- return ret;
+ return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
+ lp87565_cells, ARRAY_SIZE(lp87565_cells),
+ NULL, 0, NULL);
}
static const struct i2c_device_id lp87565_id_table[] = {
--
2.9.3
[toc] | [next] | [standalone]
| From | Keerthy <j-keerthy@ti.com> |
|---|---|
| Date | 2017-07-31 06:20 +0200 |
| Message-ID | <u9als-1ss-11@gated-at.bofh.it> |
| In reply to | #1699512 |
On Sunday 30 July 2017 04:28 PM, Axel Lin wrote:
> This fixes missing mfd_remove_devices() call when unload the module.
Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/lp87565.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
> index 340ad0c..32d2a07 100644
> --- a/drivers/mfd/lp87565.c
> +++ b/drivers/mfd/lp87565.c
> @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
>
> i2c_set_clientdata(client, lp87565);
>
> - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
> - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
> -
> - return ret;
> + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
> + lp87565_cells, ARRAY_SIZE(lp87565_cells),
> + NULL, 0, NULL);
> }
>
> static const struct i2c_device_id lp87565_id_table[] = {
>
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-08-08 12:10 +0200 |
| Message-ID | <uc9Cy-6yS-17@gated-at.bofh.it> |
| In reply to | #1699512 |
On Sun, 30 Jul 2017, Axel Lin wrote:
> This fixes missing mfd_remove_devices() call when unload the module.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/lp87565.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
> index 340ad0c..32d2a07 100644
> --- a/drivers/mfd/lp87565.c
> +++ b/drivers/mfd/lp87565.c
> @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
>
> i2c_set_clientdata(client, lp87565);
>
> - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
> - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
> -
> - return ret;
> + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
> + lp87565_cells, ARRAY_SIZE(lp87565_cells),
> + NULL, 0, NULL);
> }
>
> static const struct i2c_device_id lp87565_id_table[] = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web