[PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices

From	Axel Lin <axel.lin@ingics.com>
Newsgroups	linux.kernel
Subject	[PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices
Date	2017-07-30 13:00 +0200
Message-ID	<u8U6Z-7Fp-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

This fixes missing mfd_remove_devices() call when unload the module.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/mfd/lp87565.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
index 340ad0c..32d2a07 100644
--- a/drivers/mfd/lp87565.c
+++ b/drivers/mfd/lp87565.c
@@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
 
 	i2c_set_clientdata(client, lp87565);
 
-	ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
-			      ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
-
-	return ret;
+	return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
+				    lp87565_cells, ARRAY_SIZE(lp87565_cells),
+				    NULL, 0, NULL);
 }
 
 static const struct i2c_device_id lp87565_id_table[] = {
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Axel Lin <axel.lin@ingics.com> - 2017-07-30 13:00 +0200
  Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Keerthy <j-keerthy@ti.com> - 2017-07-31 06:20 +0200
  Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Lee Jones <lee.jones@linaro.org> - 2017-08-08 12:10 +0200

csiph-web