Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1701994 > unrolled thread
| Started by | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| First post | 2017-08-02 12:40 +0200 |
| Last post | 2017-08-09 18:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] power: add const to bin_attribute structures Bhumika Goyal <bhumirks@gmail.com> - 2017-08-02 12:40 +0200
Re: [PATCH] power: add const to bin_attribute structures Bhumika Goyal <bhumirks@gmail.com> - 2017-08-02 16:30 +0200
Re: [PATCH] power: add const to bin_attribute structures Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-08-09 18:00 +0200
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-08-02 12:40 +0200 |
| Subject | [PATCH] power: add const to bin_attribute structures |
| Message-ID | <u9Zei-eC-19@gated-at.bofh.it> |
Add const to bin_attribute structures as they are only passed to the
functions sysfs_{remove/create}_bin_file or
device_{remove/create}_bin_file. The corresponding parameters
passed are of type const, so declare the structures to be const.
Done using Coccinelle:
@m disable optional_qualifier@
identifier s;
position p;
@@
static struct bin_attribute s@p={...};
@okay1@
position p;
identifier m.s;
@@
(
sysfs_create_bin_file(...,&s@p,...)
|
sysfs_remove_bin_file(...,&s@p,...)
)
@bad@
position p!={m.p,okay1.p};
identifier m.s;
@@
s@p
@change depends on !bad disable optional_qualifier@
identifier m.s;
@@
static
+const
struct bin_attribute s={...};
Same script was modified for device_{create/remove}_bin_file functions.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
Could not find an architecture to cross compile olpc_battery.o file.
drivers/power/supply/ds2780_battery.c | 4 ++--
drivers/power/supply/ds2781_battery.c | 4 ++--
drivers/power/supply/olpc_battery.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/power/supply/ds2780_battery.c b/drivers/power/supply/ds2780_battery.c
index 8edd4aa..e5d81b4 100644
--- a/drivers/power/supply/ds2780_battery.c
+++ b/drivers/power/supply/ds2780_battery.c
@@ -663,7 +663,7 @@ static ssize_t ds2780_write_param_eeprom_bin(struct file *filp,
return count;
}
-static struct bin_attribute ds2780_param_eeprom_bin_attr = {
+static const struct bin_attribute ds2780_param_eeprom_bin_attr = {
.attr = {
.name = "param_eeprom",
.mode = S_IRUGO | S_IWUSR,
@@ -708,7 +708,7 @@ static ssize_t ds2780_write_user_eeprom_bin(struct file *filp,
return count;
}
-static struct bin_attribute ds2780_user_eeprom_bin_attr = {
+static const struct bin_attribute ds2780_user_eeprom_bin_attr = {
.attr = {
.name = "user_eeprom",
.mode = S_IRUGO | S_IWUSR,
diff --git a/drivers/power/supply/ds2781_battery.c b/drivers/power/supply/ds2781_battery.c
index 4400402..efe83ef 100644
--- a/drivers/power/supply/ds2781_battery.c
+++ b/drivers/power/supply/ds2781_battery.c
@@ -665,7 +665,7 @@ static ssize_t ds2781_write_param_eeprom_bin(struct file *filp,
return count;
}
-static struct bin_attribute ds2781_param_eeprom_bin_attr = {
+static const struct bin_attribute ds2781_param_eeprom_bin_attr = {
.attr = {
.name = "param_eeprom",
.mode = S_IRUGO | S_IWUSR,
@@ -711,7 +711,7 @@ static ssize_t ds2781_write_user_eeprom_bin(struct file *filp,
return count;
}
-static struct bin_attribute ds2781_user_eeprom_bin_attr = {
+static const struct bin_attribute ds2781_user_eeprom_bin_attr = {
.attr = {
.name = "user_eeprom",
.mode = S_IRUGO | S_IWUSR,
diff --git a/drivers/power/supply/olpc_battery.c b/drivers/power/supply/olpc_battery.c
index 9e29b13..fc20ca3 100644
--- a/drivers/power/supply/olpc_battery.c
+++ b/drivers/power/supply/olpc_battery.c
@@ -535,7 +535,7 @@ static ssize_t olpc_bat_eeprom_read(struct file *filp, struct kobject *kobj,
return count;
}
-static struct bin_attribute olpc_bat_eeprom = {
+static const struct bin_attribute olpc_bat_eeprom = {
.attr = {
.name = "eeprom",
.mode = S_IRUGO,
--
1.9.1
[toc] | [next] | [standalone]
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-08-02 16:30 +0200 |
| Message-ID | <ua2OR-2xp-11@gated-at.bofh.it> |
| In reply to | #1701994 |
On Wed, Aug 2, 2017 at 3:59 PM, Bhumika Goyal <bhumirks@gmail.com> wrote:
> Add const to bin_attribute structures as they are only passed to the
> functions sysfs_{remove/create}_bin_file or
> device_{remove/create}_bin_file. The corresponding parameters
> passed are of type const, so declare the structures to be const.
>
> Done using Coccinelle:
>
> @m disable optional_qualifier@
> identifier s;
> position p;
> @@
> static struct bin_attribute s@p={...};
>
> @okay1@
> position p;
> identifier m.s;
> @@
> (
> sysfs_create_bin_file(...,&s@p,...)
> |
> sysfs_remove_bin_file(...,&s@p,...)
> )
>
> @bad@
> position p!={m.p,okay1.p};
> identifier m.s;
> @@
> s@p
>
> @change depends on !bad disable optional_qualifier@
> identifier m.s;
> @@
> static
> +const
> struct bin_attribute s={...};
>
> Same script was modified for device_{create/remove}_bin_file functions.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> Could not find an architecture to cross compile olpc_battery.o file.
>
Any suggestions on how to cross compile olpc_battery.o file?
The configuration option for this file did not match any architecture.
Thanks,
Bhumika
> drivers/power/supply/ds2780_battery.c | 4 ++--
> drivers/power/supply/ds2781_battery.c | 4 ++--
> drivers/power/supply/olpc_battery.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/power/supply/ds2780_battery.c b/drivers/power/supply/ds2780_battery.c
> index 8edd4aa..e5d81b4 100644
> --- a/drivers/power/supply/ds2780_battery.c
> +++ b/drivers/power/supply/ds2780_battery.c
> @@ -663,7 +663,7 @@ static ssize_t ds2780_write_param_eeprom_bin(struct file *filp,
> return count;
> }
>
> -static struct bin_attribute ds2780_param_eeprom_bin_attr = {
> +static const struct bin_attribute ds2780_param_eeprom_bin_attr = {
> .attr = {
> .name = "param_eeprom",
> .mode = S_IRUGO | S_IWUSR,
> @@ -708,7 +708,7 @@ static ssize_t ds2780_write_user_eeprom_bin(struct file *filp,
> return count;
> }
>
> -static struct bin_attribute ds2780_user_eeprom_bin_attr = {
> +static const struct bin_attribute ds2780_user_eeprom_bin_attr = {
> .attr = {
> .name = "user_eeprom",
> .mode = S_IRUGO | S_IWUSR,
> diff --git a/drivers/power/supply/ds2781_battery.c b/drivers/power/supply/ds2781_battery.c
> index 4400402..efe83ef 100644
> --- a/drivers/power/supply/ds2781_battery.c
> +++ b/drivers/power/supply/ds2781_battery.c
> @@ -665,7 +665,7 @@ static ssize_t ds2781_write_param_eeprom_bin(struct file *filp,
> return count;
> }
>
> -static struct bin_attribute ds2781_param_eeprom_bin_attr = {
> +static const struct bin_attribute ds2781_param_eeprom_bin_attr = {
> .attr = {
> .name = "param_eeprom",
> .mode = S_IRUGO | S_IWUSR,
> @@ -711,7 +711,7 @@ static ssize_t ds2781_write_user_eeprom_bin(struct file *filp,
> return count;
> }
>
> -static struct bin_attribute ds2781_user_eeprom_bin_attr = {
> +static const struct bin_attribute ds2781_user_eeprom_bin_attr = {
> .attr = {
> .name = "user_eeprom",
> .mode = S_IRUGO | S_IWUSR,
> diff --git a/drivers/power/supply/olpc_battery.c b/drivers/power/supply/olpc_battery.c
> index 9e29b13..fc20ca3 100644
> --- a/drivers/power/supply/olpc_battery.c
> +++ b/drivers/power/supply/olpc_battery.c
> @@ -535,7 +535,7 @@ static ssize_t olpc_bat_eeprom_read(struct file *filp, struct kobject *kobj,
> return count;
> }
>
> -static struct bin_attribute olpc_bat_eeprom = {
> +static const struct bin_attribute olpc_bat_eeprom = {
> .attr = {
> .name = "eeprom",
> .mode = S_IRUGO,
> --
> 1.9.1
>
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Reichel <sebastian.reichel@collabora.co.uk> |
|---|---|
| Date | 2017-08-09 18:00 +0200 |
| Message-ID | <ucByO-T5-1@gated-at.bofh.it> |
| In reply to | #1701994 |
[Multipart message — attachments visible in raw view] — view raw
Hi,
On Wed, Aug 02, 2017 at 03:59:38PM +0530, Bhumika Goyal wrote:
> Add const to bin_attribute structures as they are only passed to the
> functions sysfs_{remove/create}_bin_file or
> device_{remove/create}_bin_file. The corresponding parameters
> passed are of type const, so declare the structures to be const.
>
> Done using Coccinelle:
>
> @m disable optional_qualifier@
> identifier s;
> position p;
> @@
> static struct bin_attribute s@p={...};
>
> @okay1@
> position p;
> identifier m.s;
> @@
> (
> sysfs_create_bin_file(...,&s@p,...)
> |
> sysfs_remove_bin_file(...,&s@p,...)
> )
>
> @bad@
> position p!={m.p,okay1.p};
> identifier m.s;
> @@
> s@p
>
> @change depends on !bad disable optional_qualifier@
> identifier m.s;
> @@
> static
> +const
> struct bin_attribute s={...};
>
> Same script was modified for device_{create/remove}_bin_file functions.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Thanks, applied.
> Could not find an architecture to cross compile olpc_battery.o file.
OLPC is a 32 bit x86 system.
> drivers/power/supply/ds2780_battery.c | 4 ++--
> drivers/power/supply/ds2781_battery.c | 4 ++--
> drivers/power/supply/olpc_battery.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
-- Sebastian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web