Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1707433

Re: [PATCH] power: add const to bin_attribute structures

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Aug 02, 2017 at 03:59:38PM +0530, Bhumika Goyal wrote:
> Add const to bin_attribute structures as they are only passed to the
> functions sysfs_{remove/create}_bin_file or
> device_{remove/create}_bin_file. The corresponding parameters
> passed are of type const, so declare the structures to be const.
> 
> Done using Coccinelle:
> 
> @m disable optional_qualifier@
> identifier s;
> position p;
> @@
> static struct bin_attribute s@p={...};
> 
> @okay1@
> position p;
> identifier m.s;
> @@
> (
> sysfs_create_bin_file(...,&s@p,...)
> |
> sysfs_remove_bin_file(...,&s@p,...)
> )
> 
> @bad@
> position p!={m.p,okay1.p};
> identifier m.s;
> @@
> s@p
> 
> @change depends on !bad disable optional_qualifier@
> identifier m.s;
> @@
> static
> +const
> struct bin_attribute s={...};
> 
> Same script was modified for device_{create/remove}_bin_file functions.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---

Thanks, applied.

> Could not find an architecture to cross compile olpc_battery.o file.

OLPC is a 32 bit x86 system.

>  drivers/power/supply/ds2780_battery.c | 4 ++--
>  drivers/power/supply/ds2781_battery.c | 4 ++--
>  drivers/power/supply/olpc_battery.c   | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] power: add const to bin_attribute structures Bhumika Goyal <bhumirks@gmail.com> - 2017-08-02 12:40 +0200
  Re: [PATCH] power: add const to bin_attribute structures Bhumika Goyal <bhumirks@gmail.com> - 2017-08-02 16:30 +0200
  Re: [PATCH] power: add const to bin_attribute structures Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-08-09 18:00 +0200

csiph-web