Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1700896 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-01 13:40 +0200 |
| Last post | 2017-08-03 17:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 4/6] mtd: nand: vf610_nfc: Handle return value of clk_prepare_enable. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 13:40 +0200
Re: [PATCH 4/6] mtd: nand: vf610_nfc: Handle return value of clk_prepare_enable. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-03 17:30 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-01 13:40 +0200 |
| Subject | [PATCH 4/6] mtd: nand: vf610_nfc: Handle return value of clk_prepare_enable. |
| Message-ID | <u9DGO-3pR-13@gated-at.bofh.it> |
clk_prepare_enable() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/mtd/nand/vf610_nfc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
index 744ab10..db03d4f 100644
--- a/drivers/mtd/nand/vf610_nfc.c
+++ b/drivers/mtd/nand/vf610_nfc.c
@@ -816,10 +816,13 @@ static int vf610_nfc_resume(struct device *dev)
{
struct mtd_info *mtd = dev_get_drvdata(dev);
struct vf610_nfc *nfc = mtd_to_nfc(mtd);
+ int ret;
pinctrl_pm_select_default_state(dev);
- clk_prepare_enable(nfc->clk);
+ ret = clk_prepare_enable(nfc->clk);
+ if (ret)
+ return ret;
vf610_nfc_preinit_controller(nfc);
vf610_nfc_init_controller(nfc);
--
1.9.1
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-08-03 17:30 +0200 |
| Subject | Re: [PATCH 4/6] mtd: nand: vf610_nfc: Handle return value of clk_prepare_enable. |
| Message-ID | <uaqeu-1Q1-3@gated-at.bofh.it> |
| In reply to | #1700896 |
On Tue, 1 Aug 2017 17:09:18 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> clk_prepare_enable() can fail here and we must check its return value.
You're just a few days late, this one has already been proposed by
Fabio [1] ;-).
I'll queue other patches from this patchset.
Thanks,
Boris
[1]https://patchwork.ozlabs.org/patch/789812/
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/mtd/nand/vf610_nfc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
> index 744ab10..db03d4f 100644
> --- a/drivers/mtd/nand/vf610_nfc.c
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -816,10 +816,13 @@ static int vf610_nfc_resume(struct device *dev)
> {
> struct mtd_info *mtd = dev_get_drvdata(dev);
> struct vf610_nfc *nfc = mtd_to_nfc(mtd);
> + int ret;
>
> pinctrl_pm_select_default_state(dev);
>
> - clk_prepare_enable(nfc->clk);
> + ret = clk_prepare_enable(nfc->clk);
> + if (ret)
> + return ret;
>
> vf610_nfc_preinit_controller(nfc);
> vf610_nfc_init_controller(nfc);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web