Re: [PATCH 4/6] mtd: nand: vf610_nfc: Handle return value of clk_prepare_enable.

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] mtd: nand: vf610_nfc: Handle return value of clk_prepare_enable.
Date	2017-08-03 17:30 +0200
Message-ID	<uaqeu-1Q1-3@gated-at.bofh.it> (permalink)
References	<u9DGO-3pR-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue,  1 Aug 2017 17:09:18 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> clk_prepare_enable() can fail here and we must check its return value.

You're just a few days late, this one has already been proposed by
Fabio [1] ;-).

I'll queue other patches from this patchset.

Thanks,

Boris

[1]https://patchwork.ozlabs.org/patch/789812/

> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/mtd/nand/vf610_nfc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
> index 744ab10..db03d4f 100644
> --- a/drivers/mtd/nand/vf610_nfc.c
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -816,10 +816,13 @@ static int vf610_nfc_resume(struct device *dev)
>  {
>  	struct mtd_info *mtd = dev_get_drvdata(dev);
>  	struct vf610_nfc *nfc = mtd_to_nfc(mtd);
> +	int ret;
>  
>  	pinctrl_pm_select_default_state(dev);
>  
> -	clk_prepare_enable(nfc->clk);
> +	ret = clk_prepare_enable(nfc->clk);
> +	if (ret)
> +		return ret;
>  
>  	vf610_nfc_preinit_controller(nfc);
>  	vf610_nfc_init_controller(nfc);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] mtd: nand: vf610_nfc: Handle return value of clk_prepare_enable. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 13:40 +0200
  Re: [PATCH 4/6] mtd: nand: vf610_nfc: Handle return value of  clk_prepare_enable. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-03 17:30 +0200

csiph-web