Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698882 > unrolled thread

[PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues.

Started byEgil Hjelmeland <privat@egil-hjelmeland.no>
First post2017-07-28 17:20 +0200
Last post2017-07-28 17:30 +0200
Articles 4 on this page of 24 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues. Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
    [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
      Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy  access functions Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
      Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:50 +0200
      Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy  access functions Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
    [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
      Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get  MDIO register Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
      Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:40 +0200
      Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO  register Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
    [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
      Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix  lan9303_detect_phy_setup() for MDIO Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:20 +0200
      Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:40 +0200
      Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix  lan9303_detect_phy_setup() for MDIO Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
    [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
      Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy  registers directly Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
      Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:50 +0200
        Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers  directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 18:30 +0200
          Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 19:00 +0200
            Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers  directly Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
              Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers  directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 21:50 +0200
                Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy  registers directly Andrew Lunn <andrew@lunn.ch> - 2017-07-28 23:30 +0200
                  Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers  directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-29 00:40 +0200
              RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy  registers directly David Laight <David.Laight@ACULAB.COM> - 2017-07-31 13:50 +0200
    Re: [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues. Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1699119 — Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

FromAndrew Lunn <andrew@lunn.ch>
Date2017-07-28 23:30 +0200
SubjectRe: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly
Message-ID<u8kZA-Mn-13@gated-at.bofh.it>
In reply to#1699044
> >Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem
> >to be appropriate, which can be done as a subsequent patch.
> >
> >Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> >
> I have no idea how these legalities work. But for the record,
> I give consent to change to EXPORT_SYMBOL_GPL at any time.

Hi Egil

What is better, is that when somebody posts such a patch, send an
Acked-by: It will get added to the patch, leaving a record in git that
you agreed to the change.

    Andrew

[toc] | [prev] | [next] | [standalone]

#1699142 — Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

FromEgil Hjelmeland <privat@egil-hjelmeland.no>
Date2017-07-29 00:40 +0200
SubjectRe: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly
Message-ID<u8m5k-1tQ-35@gated-at.bofh.it>
In reply to#1699119
Den 28. juli 2017 23:28, skrev Andrew Lunn:
>>> Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem
>>> to be appropriate, which can be done as a subsequent patch.
>>>
>>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>>
>> I have no idea how these legalities work. But for the record,
>> I give consent to change to EXPORT_SYMBOL_GPL at any time.
> 
> Hi Egil
> 
> What is better, is that when somebody posts such a patch, send an
> Acked-by: It will get added to the patch, leaving a record in git that
> you agreed to the change.
> 
>      Andrew
> 

In case I think I prefer to get off the hook now by issuing
a PATCH v2 adding "_GPL" when I show up in office Monday.

Egil

[toc] | [prev] | [next] | [standalone]

#1699962 — RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

FromDavid Laight <David.Laight@ACULAB.COM>
Date2017-07-31 13:50 +0200
SubjectRE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly
Message-ID<u9hmV-5Mi-3@gated-at.bofh.it>
In reply to#1698965
From: Florian Fainelli
> Sent: 28 July 2017 18:05
...
> >>>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops);
> >>>
> >>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL?
> >>
> >> I have no opinion. I just used the same variant as the other EXPORTS
> >> in the file.
> >
> > If there is no concern from others about this, LGTM too:
> 
> Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem
> to be appropriate, which can be done as a subsequent patch.

It depends on whether the function needs to be usable by 'out of tree'
non-GPL modules.
This looks like a 'private' export between related modules.
The problems arise with functions like put_ns() and put_pid()
which can easily be needed by non-GPL code.

	David

[toc] | [prev] | [next] | [standalone]

#1698897

FromAndrew Lunn <andrew@lunn.ch>
Date2017-07-28 17:30 +0200
Message-ID<u8fnb-5vv-3@gated-at.bofh.it>
In reply to#1698882
On Fri, Jul 28, 2017 at 05:11:53PM +0200, Egil Hjelmeland wrote:
> This series fix the MDIO interface for the lan9303 DSA driver.
> Bugs found after testing on actual HW.
> 
> This series is extracted from the first patch of my first large
> series.

Hi Egil

Thanks for breaking the patch up. It was much easier to understand and
review.

	Andrew

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web