Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698207 > unrolled thread

[RFT v2 0/3] ASoC: samsung: s3c24xx: Fixes for error paths

Started byKrzysztof Kozlowski <krzk@kernel.org>
First post2017-07-27 19:20 +0200
Last post2017-07-28 07:50 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [RFT v2 0/3] ASoC: samsung: s3c24xx: Fixes for error paths Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-27 19:20 +0200
    [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-27 19:20 +0200
      Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of  s3c24xx Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-28 06:50 +0200
        Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of  s3c24xx Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-28 07:50 +0200

#1698207 — [RFT v2 0/3] ASoC: samsung: s3c24xx: Fixes for error paths

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2017-07-27 19:20 +0200
Subject[RFT v2 0/3] ASoC: samsung: s3c24xx: Fixes for error paths
Message-ID<u7UC6-sM-5@gated-at.bofh.it>
Hi,

Changes since v1:
1. Add patch 2/3.
2. Drop assignment of iis_cclk=iis_pclk to have balance with clk disables error
   and remove paths (pointed by Arvind).

Best regards,
Krzysztof


Krzysztof Kozlowski (3):
  ASoC: samsung: Fix possible double iounmap on s3c24xx driver probe
    failure
  ASoC: samsung: Add missing prepare for iis clock of s3c24xx
  ASoC: samsung: Add proper error paths to s3c24xx I2S driver

 sound/soc/samsung/s3c-i2s-v2.c  | 12 ++++++++++--
 sound/soc/samsung/s3c-i2s-v2.h  |  7 +++++++
 sound/soc/samsung/s3c2412-i2s.c | 13 +++++++++----
 3 files changed, 26 insertions(+), 6 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1698208 — [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2017-07-27 19:20 +0200
Subject[RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx
Message-ID<u7UC6-sM-13@gated-at.bofh.it>
In reply to#1698207
The s3c_i2sv2_probe() only enabled iis clock.  Missing prepare isn't
probably fatal, because for SoC clocks this is usually no-op, but for
correctness this clock should be prepared.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. New patch
---
 sound/soc/samsung/s3c-i2s-v2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
index 9b28046eea8e..3894bda06ebb 100644
--- a/sound/soc/samsung/s3c-i2s-v2.c
+++ b/sound/soc/samsung/s3c-i2s-v2.c
@@ -637,7 +637,7 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai,
 		return -ENOENT;
 	}
 
-	clk_enable(i2s->iis_pclk);
+	clk_prepare_enable(i2s->iis_pclk);
 
 	/* Mark ourselves as in TXRX mode so we can run through our cleanup
 	 * process without warnings. */
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1698467 — Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-28 06:50 +0200
SubjectRe: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx
Message-ID<u85nQ-7rT-11@gated-at.bofh.it>
In reply to#1698208
Hi,


On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote:
> The s3c_i2sv2_probe() only enabled iis clock.  Missing prepare isn't
> probably fatal, because for SoC clocks this is usually no-op, but for
> correctness this clock should be prepared.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. New patch
> ---
>   sound/soc/samsung/s3c-i2s-v2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
> index 9b28046eea8e..3894bda06ebb 100644
> --- a/sound/soc/samsung/s3c-i2s-v2.c
> +++ b/sound/soc/samsung/s3c-i2s-v2.c
> @@ -637,7 +637,7 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai,
>   		return -ENOENT;
>   	}
>   
> -	clk_enable(i2s->iis_pclk);
> +	clk_prepare_enable(i2s->iis_pclk);
Please, handle are return value of clk_prepare_enble.
>   
>   	/* Mark ourselves as in TXRX mode so we can run through our cleanup
>   	 * process without warnings. */
~arvind

[toc] | [prev] | [next] | [standalone]

#1698480 — Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

FromKrzysztof Kozlowski <krzk@kernel.org>
Date2017-07-28 07:50 +0200
SubjectRe: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx
Message-ID<u86jT-81O-1@gated-at.bofh.it>
In reply to#1698467
On Fri, Jul 28, 2017 at 10:11:48AM +0530, Arvind Yadav wrote:
> Hi,
> 
> 
> On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote:
> >The s3c_i2sv2_probe() only enabled iis clock.  Missing prepare isn't
> >probably fatal, because for SoC clocks this is usually no-op, but for
> >correctness this clock should be prepared.
> >
> >Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> >---
> >
> >Changes since v1:
> >1. New patch
> >---
> >  sound/soc/samsung/s3c-i2s-v2.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
> >index 9b28046eea8e..3894bda06ebb 100644
> >--- a/sound/soc/samsung/s3c-i2s-v2.c
> >+++ b/sound/soc/samsung/s3c-i2s-v2.c
> >@@ -637,7 +637,7 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai,
> >  		return -ENOENT;
> >  	}
> >-	clk_enable(i2s->iis_pclk);
> >+	clk_prepare_enable(i2s->iis_pclk);
> Please, handle are return value of clk_prepare_enble.

Which is a different issue, different bug. We can fix it but it should
be not mixed with this fix here.

Best regards,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web