Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1698208
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx |
| Date | 2017-07-27 19:20 +0200 |
| Message-ID | <u7UC6-sM-13@gated-at.bofh.it> (permalink) |
| References | <u7UC6-sM-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't probably fatal, because for SoC clocks this is usually no-op, but for correctness this clock should be prepared. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v1: 1. New patch --- sound/soc/samsung/s3c-i2s-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c index 9b28046eea8e..3894bda06ebb 100644 --- a/sound/soc/samsung/s3c-i2s-v2.c +++ b/sound/soc/samsung/s3c-i2s-v2.c @@ -637,7 +637,7 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai, return -ENOENT; } - clk_enable(i2s->iis_pclk); + clk_prepare_enable(i2s->iis_pclk); /* Mark ourselves as in TXRX mode so we can run through our cleanup * process without warnings. */ -- 2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFT v2 0/3] ASoC: samsung: s3c24xx: Fixes for error paths Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-27 19:20 +0200
[RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-27 19:20 +0200
Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-28 06:50 +0200
Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-28 07:50 +0200
csiph-web