Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694278 > unrolled thread

[PATCH 0/9] constify tty pci_device_id.

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-07-23 12:10 +0200
Last post2017-07-23 12:10 +0200
Articles 3 — 1 participant

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/9] constify tty pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-23 12:10 +0200
    [PATCH 7/9] tty: serial: exar: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-23 12:10 +0200
    [PATCH 6/9] tty: serial: pci: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-23 12:10 +0200

#1694278 — [PATCH 0/9] constify tty pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-23 12:10 +0200
Subject[PATCH 0/9] constify tty pci_device_id.
Message-ID<u6lZM-6dR-7@gated-at.bofh.it>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Arvind Yadav (9):
  [PATCH 1/9] tty: mxser: constify pci_device_id.
  [PATCH 2/9] tty: isicom: constify pci_device_id.
  [PATCH 3/9] tty: synclinkmp: constify pci_device_id.
  [PATCH 4/9] tty: synclink: constify pci_device_id.
  [PATCH 5/9] tty: moxa: constify pci_device_id.
  [PATCH 6/9] tty: serial: pci: constify pci_device_id.
  [PATCH 7/9] tty: serial: exar: constify pci_device_id.
  [PATCH 8/9] tty: serial: jsm: constify pci_device_id.
  [PATCH 9/9] tty: synclink_gt: constify pci_device_id.

 drivers/tty/isicom.c                | 2 +-
 drivers/tty/moxa.c                  | 2 +-
 drivers/tty/mxser.c                 | 2 +-
 drivers/tty/serial/8250/8250_exar.c | 2 +-
 drivers/tty/serial/8250/8250_pci.c  | 2 +-
 drivers/tty/serial/jsm/jsm_driver.c | 2 +-
 drivers/tty/synclink.c              | 2 +-
 drivers/tty/synclink_gt.c           | 2 +-
 drivers/tty/synclinkmp.c            | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1694279 — [PATCH 7/9] tty: serial: exar: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-23 12:10 +0200
Subject[PATCH 7/9] tty: serial: exar: constify pci_device_id.
Message-ID<u6lZM-6dR-15@gated-at.bofh.it>
In reply to#1694278
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   4030	   1280	      0	   5310	   14be	tty/serial/8250/8250_exar.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   4958	    352	      0	   5310	   14be	tty/serial/8250/8250_exar.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/tty/serial/8250/8250_exar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index b5c98e5..6f031fc 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -601,7 +601,7 @@ static const struct exar8250_board pbn_exar_XR17V8358 = {
 		(kernel_ulong_t)&bd			\
 	}
 
-static struct pci_device_id exar_pci_tbl[] = {
+static const struct pci_device_id exar_pci_tbl[] = {
 	CONNECT_DEVICE(XR17C152, UART_2_232, pbn_connect),
 	CONNECT_DEVICE(XR17C154, UART_4_232, pbn_connect),
 	CONNECT_DEVICE(XR17C158, UART_8_232, pbn_connect),
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1694280 — [PATCH 6/9] tty: serial: pci: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-23 12:10 +0200
Subject[PATCH 6/9] tty: serial: pci: constify pci_device_id.
Message-ID<u6lZM-6dR-17@gated-at.bofh.it>
In reply to#1694278
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  12626	  18128	      0	  30754	   7822 tty/serial/8250/8250_pci.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  23986	   6768	      0	  30754	   7822 tty/serial/8250/8250_pci.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/tty/serial/8250/8250_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 00e51a0..553823c 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -3723,7 +3723,7 @@ static int pciserial_resume_one(struct device *dev)
 static SIMPLE_DEV_PM_OPS(pciserial_pm_ops, pciserial_suspend_one,
 			 pciserial_resume_one);
 
-static struct pci_device_id serial_pci_tbl[] = {
+static const struct pci_device_id serial_pci_tbl[] = {
 	/* Advantech use PCI_DEVICE_ID_ADVANTECH_PCI3620 (0x3620) as 'PCI_SUBVENDOR_ID' */
 	{	PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620,
 		PCI_DEVICE_ID_ADVANTECH_PCI3620, 0x0001, 0, 0,
-- 
2.7.4

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web