[PATCH 6/9] tty: serial: pci: constify pci_device_id.

From	Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 6/9] tty: serial: pci: constify pci_device_id.
Date	2017-07-23 12:10 +0200
Message-ID	<u6lZM-6dR-17@gated-at.bofh.it> (permalink)
References	<u6lZM-6dR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  12626	  18128	      0	  30754	   7822 tty/serial/8250/8250_pci.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  23986	   6768	      0	  30754	   7822 tty/serial/8250/8250_pci.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/tty/serial/8250/8250_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 00e51a0..553823c 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -3723,7 +3723,7 @@ static int pciserial_resume_one(struct device *dev)
 static SIMPLE_DEV_PM_OPS(pciserial_pm_ops, pciserial_suspend_one,
 			 pciserial_resume_one);
 
-static struct pci_device_id serial_pci_tbl[] = {
+static const struct pci_device_id serial_pci_tbl[] = {
 	/* Advantech use PCI_DEVICE_ID_ADVANTECH_PCI3620 (0x3620) as 'PCI_SUBVENDOR_ID' */
 	{	PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620,
 		PCI_DEVICE_ID_ADVANTECH_PCI3620, 0x0001, 0, 0,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] constify tty pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-23 12:10 +0200
  [PATCH 7/9] tty: serial: exar: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-23 12:10 +0200
  [PATCH 6/9] tty: serial: pci: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-23 12:10 +0200

csiph-web