Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692981 > unrolled thread

[PATCH v2 2/2] Telemetry: remove redundant macro definition

Started byRajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
First post2017-07-20 16:30 +0200
Last post2017-07-24 11:30 +0200
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 2/2] Telemetry: remove redundant macro definition Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-07-20 16:30 +0200
    RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition "Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com> - 2017-07-21 05:20 +0200
    RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition "Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com> - 2017-07-21 05:30 +0200
      Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition Darren Hart <dvhart@infradead.org> - 2017-07-22 01:10 +0200
        Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-24 11:30 +0200

#1692981 — [PATCH v2 2/2] Telemetry: remove redundant macro definition

FromRajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Date2017-07-20 16:30 +0200
Subject[PATCH v2 2/2] Telemetry: remove redundant macro definition
Message-ID<u5kCJ-ew-17@gated-at.bofh.it>
Telemetry driver includes intel_telemetry.h which defines
TELEM_MAX_OS_ALLOCATED_EVENTS already.

Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
---
 drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 6393b3b1d5a6..e0424d5a795a 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -46,7 +46,6 @@
 #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
 
 #define TELEM_MAX_EVENTS_SRAM		28
-#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
 #define TELEM_SSRAM_STARTTIME_OFFSET	8
 #define TELEM_SSRAM_EVTLOG_OFFSET	16
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1693359

From"Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com>
Date2017-07-21 05:20 +0200
Message-ID<u5wDT-7RF-3@gated-at.bofh.it>
In reply to#1692981
Both set of two looks good. +1.

> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-
> x86-owner@vger.kernel.org] On Behalf Of Rajneesh Bhardwaj
> Sent: Thursday, July 20, 2017 7:51 PM
> To: platform-driver-x86@vger.kernel.org
> Cc: dvhart@infradead.org; andy@infradead.org; linux-
> kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
> Rajneesh <rajneesh.bhardwaj@intel.com>
> Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Telemetry driver includes intel_telemetry.h which defines
> TELEM_MAX_OS_ALLOCATED_EVENTS already.
> 
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> ---
>  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 6393b3b1d5a6..e0424d5a795a 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -46,7 +46,6 @@
>  #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
> 
>  #define TELEM_MAX_EVENTS_SRAM		28
> -#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
>  #define TELEM_SSRAM_STARTTIME_OFFSET	8
>  #define TELEM_SSRAM_EVTLOG_OFFSET	16
> 
> --
> 2.7.4

[toc] | [prev] | [next] | [standalone]

#1693362

From"Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com>
Date2017-07-21 05:30 +0200
Message-ID<u5wNA-7UM-5@gated-at.bofh.it>
In reply to#1692981
Just missed the email from Darren.

Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@intel.com>

> -----Original Message-----
> From: Chakravarty, Souvik K
> Sent: Friday, July 21, 2017 8:45 AM
> To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@intel.com>; platform-driver-
> x86@vger.kernel.org
> Cc: dvhart@infradead.org; andy@infradead.org; linux-
> kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> Bhardwaj, Rajneesh <rajneesh.bhardwaj@intel.com>
> Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Both set of two looks good. +1.
> 
> > -----Original Message-----
> > From: platform-driver-x86-owner@vger.kernel.org
> > [mailto:platform-driver- x86-owner@vger.kernel.org] On Behalf Of
> > Rajneesh Bhardwaj
> > Sent: Thursday, July 20, 2017 7:51 PM
> > To: platform-driver-x86@vger.kernel.org
> > Cc: dvhart@infradead.org; andy@infradead.org; linux-
> > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> > Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
> > Rajneesh <rajneesh.bhardwaj@intel.com>
> > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> >
> > Telemetry driver includes intel_telemetry.h which defines
> > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> >
> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> > ---
> >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > index 6393b3b1d5a6..e0424d5a795a 100644
> > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > @@ -46,7 +46,6 @@
> >  #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
> >
> >  #define TELEM_MAX_EVENTS_SRAM		28
> > -#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
> >  #define TELEM_SSRAM_STARTTIME_OFFSET	8
> >  #define TELEM_SSRAM_EVTLOG_OFFSET	16
> >
> > --
> > 2.7.4

[toc] | [prev] | [next] | [standalone]

#1694053

FromDarren Hart <dvhart@infradead.org>
Date2017-07-22 01:10 +0200
Message-ID<u5Pdw-2yy-13@gated-at.bofh.it>
In reply to#1693362
On Fri, Jul 21, 2017 at 03:29:39AM +0000, Chakravarty, Souvik K wrote:
> Just missed the email from Darren.

:-)

> Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@intel.com>

Thank you Souvik.

While these one liners are OK for trivial changes like this, please note that
Andy and I depend on individual driver maintainers to provide thorough reviews,
and it helps to document that review to help us understand what sorts of things
you considered before approving the patch. Please keep this in mind in the
future for more complex changes.

This set is on Andy's queue, so the final review/follow-up will come from him.

Thanks,

> 
> > -----Original Message-----
> > From: Chakravarty, Souvik K
> > Sent: Friday, July 21, 2017 8:45 AM
> > To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@intel.com>; platform-driver-
> > x86@vger.kernel.org
> > Cc: dvhart@infradead.org; andy@infradead.org; linux-
> > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> > Bhardwaj, Rajneesh <rajneesh.bhardwaj@intel.com>
> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> > 
> > Both set of two looks good. +1.
> > 
> > > -----Original Message-----
> > > From: platform-driver-x86-owner@vger.kernel.org
> > > [mailto:platform-driver- x86-owner@vger.kernel.org] On Behalf Of
> > > Rajneesh Bhardwaj
> > > Sent: Thursday, July 20, 2017 7:51 PM
> > > To: platform-driver-x86@vger.kernel.org
> > > Cc: dvhart@infradead.org; andy@infradead.org; linux-
> > > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> > > Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
> > > Rajneesh <rajneesh.bhardwaj@intel.com>
> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> > >
> > > Telemetry driver includes intel_telemetry.h which defines
> > > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> > >
> > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> > > ---
> > >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > index 6393b3b1d5a6..e0424d5a795a 100644
> > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > @@ -46,7 +46,6 @@
> > >  #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
> > >
> > >  #define TELEM_MAX_EVENTS_SRAM		28
> > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
> > >  #define TELEM_SSRAM_STARTTIME_OFFSET	8
> > >  #define TELEM_SSRAM_EVTLOG_OFFSET	16
> > >
> > > --
> > > 2.7.4
> 
> 

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1694571

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-07-24 11:30 +0200
Message-ID<u6HQB-2Si-9@gated-at.bofh.it>
In reply to#1694053
On Sat, Jul 22, 2017 at 2:02 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Fri, Jul 21, 2017 at 03:29:39AM +0000, Chakravarty, Souvik K wrote:
>> Just missed the email from Darren.
>
> :-)
>
>> Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@intel.com>
>
> Thank you Souvik.
>
> While these one liners are OK for trivial changes like this, please note that
> Andy and I depend on individual driver maintainers to provide thorough reviews,
> and it helps to document that review to help us understand what sorts of things
> you considered before approving the patch. Please keep this in mind in the
> future for more complex changes.
>
> This set is on Andy's queue, so the final review/follow-up will come from him.
>

Pushed both to testing, thanks!

> Thanks,
>
>>
>> > -----Original Message-----
>> > From: Chakravarty, Souvik K
>> > Sent: Friday, July 21, 2017 8:45 AM
>> > To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@intel.com>; platform-driver-
>> > x86@vger.kernel.org
>> > Cc: dvhart@infradead.org; andy@infradead.org; linux-
>> > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
>> > Bhardwaj, Rajneesh <rajneesh.bhardwaj@intel.com>
>> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
>> >
>> > Both set of two looks good. +1.
>> >
>> > > -----Original Message-----
>> > > From: platform-driver-x86-owner@vger.kernel.org
>> > > [mailto:platform-driver- x86-owner@vger.kernel.org] On Behalf Of
>> > > Rajneesh Bhardwaj
>> > > Sent: Thursday, July 20, 2017 7:51 PM
>> > > To: platform-driver-x86@vger.kernel.org
>> > > Cc: dvhart@infradead.org; andy@infradead.org; linux-
>> > > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
>> > > Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
>> > > Rajneesh <rajneesh.bhardwaj@intel.com>
>> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
>> > >
>> > > Telemetry driver includes intel_telemetry.h which defines
>> > > TELEM_MAX_OS_ALLOCATED_EVENTS already.
>> > >
>> > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
>> > > ---
>> > >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>> > >  1 file changed, 1 deletion(-)
>> > >
>> > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > b/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > index 6393b3b1d5a6..e0424d5a795a 100644
>> > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > @@ -46,7 +46,6 @@
>> > >  #define TELEM_SAMPLING_DEFAULT_PERIOD    0xD
>> > >
>> > >  #define TELEM_MAX_EVENTS_SRAM            28
>> > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS    20
>> > >  #define TELEM_SSRAM_STARTTIME_OFFSET     8
>> > >  #define TELEM_SSRAM_EVTLOG_OFFSET        16
>> > >
>> > > --
>> > > 2.7.4
>>
>>
>
> --
> Darren Hart
> VMware Open Source Technology Center



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web