Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693362

RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition

Show all headers | View raw

Just missed the email from Darren.

Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@intel.com>

> -----Original Message-----
> From: Chakravarty, Souvik K
> Sent: Friday, July 21, 2017 8:45 AM
> To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@intel.com>; platform-driver-
> x86@vger.kernel.org
> Cc: dvhart@infradead.org; andy@infradead.org; linux-
> kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> Bhardwaj, Rajneesh <rajneesh.bhardwaj@intel.com>
> Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Both set of two looks good. +1.
> 
> > -----Original Message-----
> > From: platform-driver-x86-owner@vger.kernel.org
> > [mailto:platform-driver- x86-owner@vger.kernel.org] On Behalf Of
> > Rajneesh Bhardwaj
> > Sent: Thursday, July 20, 2017 7:51 PM
> > To: platform-driver-x86@vger.kernel.org
> > Cc: dvhart@infradead.org; andy@infradead.org; linux-
> > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> > Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
> > Rajneesh <rajneesh.bhardwaj@intel.com>
> > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> >
> > Telemetry driver includes intel_telemetry.h which defines
> > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> >
> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> > ---
> >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > index 6393b3b1d5a6..e0424d5a795a 100644
> > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > @@ -46,7 +46,6 @@
> >  #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
> >
> >  #define TELEM_MAX_EVENTS_SRAM		28
> > -#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
> >  #define TELEM_SSRAM_STARTTIME_OFFSET	8
> >  #define TELEM_SSRAM_EVTLOG_OFFSET	16
> >
> > --
> > 2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/2] Telemetry: remove redundant macro definition Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2017-07-20 16:30 +0200
  RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition "Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com> - 2017-07-21 05:20 +0200
  RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition "Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com> - 2017-07-21 05:30 +0200
    Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition Darren Hart <dvhart@infradead.org> - 2017-07-22 01:10 +0200
      Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-24 11:30 +0200

csiph-web