Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692770 > unrolled thread

[PATCH][media-next] media: v4l: make local function v4l2_fwnode_endpoint_parse_csi1_bus static

Back to article view | Back to linux.kernel

Contents

  [PATCH][media-next] media: v4l: make local function v4l2_fwnode_endpoint_parse_csi1_bus static Colin King <colin.king@canonical.com> - 2017-07-20 12:40 +0200
    Re: [PATCH][media-next] media: v4l: make local function  v4l2_fwnode_endpoint_parse_csi1_bus static Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-20 15:40 +0200

#1692770 — [PATCH][media-next] media: v4l: make local function v4l2_fwnode_endpoint_parse_csi1_bus static

From: Colin Ian King <colin.king@canonical.com>

The function v4l2_fwnode_endpoint_parse_csi1_bus does not need to be
in global scope, so make it static.  Also reformat the function arguments
as adding the static keyword made one of the source lines more than 80
chars wide and checkpatch does not like that.

Cleans up sparse warning:
"symbol 'v4l2_fwnode_endpoint_parse_csi1_bus' was not declared. Should it
be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/media/v4l2-core/v4l2-fwnode.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
index ca755a4832fc..5fd69f59d8c8 100644
--- a/drivers/media/v4l2-core/v4l2-fwnode.c
+++ b/drivers/media/v4l2-core/v4l2-fwnode.c
@@ -154,9 +154,10 @@ static void v4l2_fwnode_endpoint_parse_parallel_bus(
 
 }
 
-void v4l2_fwnode_endpoint_parse_csi1_bus(struct fwnode_handle *fwnode,
-					 struct v4l2_fwnode_endpoint *vep,
-					 u32 bus_type)
+static void v4l2_fwnode_endpoint_parse_csi1_bus(
+	struct fwnode_handle *fwnode,
+	struct v4l2_fwnode_endpoint *vep,
+	u32 bus_type)
 {
 	struct v4l2_fwnode_bus_mipi_csi1 *bus = &vep->bus.mipi_csi1;
 	u32 v;
-- 
2.11.0

[toc] | [next] | [standalone]

#1692931 — Re: [PATCH][media-next] media: v4l: make local function v4l2_fwnode_endpoint_parse_csi1_bus static

On Thu, Jul 20, 2017 at 11:30:14AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function v4l2_fwnode_endpoint_parse_csi1_bus does not need to be
> in global scope, so make it static.  Also reformat the function arguments
> as adding the static keyword made one of the source lines more than 80
> chars wide and checkpatch does not like that.
> 
> Cleans up sparse warning:
> "symbol 'v4l2_fwnode_endpoint_parse_csi1_bus' was not declared. Should it
> be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks!

Applied, with removal of an extra neline and a tab in the arguments.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web