Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692931
| From | Sakari Ailus <sakari.ailus@iki.fi> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][media-next] media: v4l: make local function v4l2_fwnode_endpoint_parse_csi1_bus static |
| Date | 2017-07-20 15:40 +0200 |
| Message-ID | <u5jQo-87F-9@gated-at.bofh.it> (permalink) |
| References | <u5h29-63o-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 20, 2017 at 11:30:14AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function v4l2_fwnode_endpoint_parse_csi1_bus does not need to be > in global scope, so make it static. Also reformat the function arguments > as adding the static keyword made one of the source lines more than 80 > chars wide and checkpatch does not like that. > > Cleans up sparse warning: > "symbol 'v4l2_fwnode_endpoint_parse_csi1_bus' was not declared. Should it > be static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks! Applied, with removal of an extra neline and a tab in the arguments. -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH][media-next] media: v4l: make local function v4l2_fwnode_endpoint_parse_csi1_bus static Colin King <colin.king@canonical.com> - 2017-07-20 12:40 +0200 Re: [PATCH][media-next] media: v4l: make local function v4l2_fwnode_endpoint_parse_csi1_bus static Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-20 15:40 +0200
csiph-web