Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692611 > unrolled thread
| Started by | Ingo Molnar <mingo@kernel.org> |
|---|---|
| First post | 2017-07-20 11:00 +0200 |
| Last post | 2017-07-20 11:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Ingo Molnar <mingo@kernel.org> - 2017-07-20 11:00 +0200
Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-20 11:20 +0200
Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration Ingo Molnar <mingo@kernel.org> - 2017-07-20 11:50 +0200
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2017-07-20 11:00 +0200 |
| Subject | Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration |
| Message-ID | <u5fto-4U4-31@gated-at.bofh.it> |
* Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add in missing void return type, fixes sparse warning:
> "warning: 'hyperv_cleanup()' has implicit return type"
>
> Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/include/asm/mshyperv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> index 01b9c0fb3aab..41fae263f8fa 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> #else /* CONFIG_HYPERV */
> static inline void hyperv_init(void) {}
> static inline bool hv_is_hypercall_page_setup(void) { return false; }
> -static inline hyperv_cleanup(void) {}
> +static inline void hyperv_cleanup(void) {}
> #endif /* CONFIG_HYPERV */
Guys, Greg, could we please move this commit from the drivers tree:
2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
arch/x86/Kbuild | 2 +-
arch/x86/include/asm/mshyperv.h | 7 ++++++-
... to the x86 tree where it belongs?
Thanks,
Ingo
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-07-20 11:20 +0200 |
| Message-ID | <u5fML-5hG-47@gated-at.bofh.it> |
| In reply to | #1692611 |
On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote:
>
> * Colin King <colin.king@canonical.com> wrote:
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Add in missing void return type, fixes sparse warning:
> > "warning: 'hyperv_cleanup()' has implicit return type"
> >
> > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/x86/include/asm/mshyperv.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > index 01b9c0fb3aab..41fae263f8fa 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> > #else /* CONFIG_HYPERV */
> > static inline void hyperv_init(void) {}
> > static inline bool hv_is_hypercall_page_setup(void) { return false; }
> > -static inline hyperv_cleanup(void) {}
> > +static inline void hyperv_cleanup(void) {}
> > #endif /* CONFIG_HYPERV */
>
> Guys, Greg, could we please move this commit from the drivers tree:
>
> 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
>
> arch/x86/Kbuild | 2 +-
> arch/x86/include/asm/mshyperv.h | 7 ++++++-
>
> ... to the x86 tree where it belongs?
I've now reverted it from my tree entirely, sorry about that.
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2017-07-20 11:50 +0200 |
| Message-ID | <u5gfM-5v3-19@gated-at.bofh.it> |
| In reply to | #1692680 |
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote:
> >
> > * Colin King <colin.king@canonical.com> wrote:
> >
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Add in missing void return type, fixes sparse warning:
> > > "warning: 'hyperv_cleanup()' has implicit return type"
> > >
> > > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > ---
> > > arch/x86/include/asm/mshyperv.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > > index 01b9c0fb3aab..41fae263f8fa 100644
> > > --- a/arch/x86/include/asm/mshyperv.h
> > > +++ b/arch/x86/include/asm/mshyperv.h
> > > @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> > > #else /* CONFIG_HYPERV */
> > > static inline void hyperv_init(void) {}
> > > static inline bool hv_is_hypercall_page_setup(void) { return false; }
> > > -static inline hyperv_cleanup(void) {}
> > > +static inline void hyperv_cleanup(void) {}
> > > #endif /* CONFIG_HYPERV */
> >
> > Guys, Greg, could we please move this commit from the drivers tree:
> >
> > 2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
> >
> > arch/x86/Kbuild | 2 +-
> > arch/x86/include/asm/mshyperv.h | 7 ++++++-
> >
> > ... to the x86 tree where it belongs?
>
> I've now reverted it from my tree entirely, sorry about that.
No problem - I'll pick up the fixed v2 version when it's posted.
Thanks,
Ingo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web