Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv_cleanup declaration
Date	2017-07-20 11:00 +0200
Message-ID	<u5fto-4U4-31@gated-at.bofh.it> (permalink)
References	<u5fto-4U4-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Add in missing void return type, fixes sparse warning:
> "warning: 'hyperv_cleanup()' has implicit return type"
> 
> Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  arch/x86/include/asm/mshyperv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> index 01b9c0fb3aab..41fae263f8fa 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
>  #else /* CONFIG_HYPERV */
>  static inline void hyperv_init(void) {}
>  static inline bool hv_is_hypercall_page_setup(void) { return false; }
> -static inline hyperv_cleanup(void) {}
> +static inline void hyperv_cleanup(void) {}
>  #endif /* CONFIG_HYPERV */

Guys, Greg, could we please move this commit from the drivers tree:

  2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set

  arch/x86/Kbuild                 | 2 +-
  arch/x86/include/asm/mshyperv.h | 7 ++++++-

... to the x86 tree where it belongs?

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH][next] x86/hyper-v: add missing void return type to  hyperv_cleanup declaration Ingo Molnar <mingo@kernel.org> - 2017-07-20 11:00 +0200
  Re: [PATCH][next] x86/hyper-v: add missing void return type to  hyperv_cleanup declaration Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-20 11:20 +0200
    Re: [PATCH][next] x86/hyper-v: add missing void return type to  hyperv_cleanup declaration Ingo Molnar <mingo@kernel.org> - 2017-07-20 11:50 +0200

csiph-web