Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692458 > unrolled thread
| Started by | "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> |
|---|---|
| First post | 2017-07-20 08:00 +0200 |
| Last post | 2017-07-21 00:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC v6 01/62] powerpc: Free up four 64K PTE bits in 4K backed HPTE pages "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2017-07-20 08:00 +0200
Re: [RFC v6 01/62] powerpc: Free up four 64K PTE bits in 4K backed HPTE pages Ram Pai <linuxram@us.ibm.com> - 2017-07-21 00:10 +0200
| From | "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-07-20 08:00 +0200 |
| Subject | Re: [RFC v6 01/62] powerpc: Free up four 64K PTE bits in 4K backed HPTE pages |
| Message-ID | <u5cFg-2W0-63@gated-at.bofh.it> |
..... > /* > @@ -116,8 +104,8 @@ int __hash_page_4K(unsigned long ea, unsigned long access, unsigned long vsid, > * On hash insert failure we use old pte value and we don't > * want slot information there if we have a insert failure. > */ > - old_pte &= ~(H_PAGE_HASHPTE | H_PAGE_F_GIX | H_PAGE_F_SECOND); > - new_pte &= ~(H_PAGE_HASHPTE | H_PAGE_F_GIX | H_PAGE_F_SECOND); > + old_pte &= ~(H_PAGE_HASHPTE); > + new_pte &= ~(H_PAGE_HASHPTE); > goto htab_insert_hpte; > } With the current path order and above hunk we will breaks the bisect I guess. With the above, when we convert a 64k hpte to 4khpte, since this is the first patch, we should clear that H_PAGE_F_GIX and H_PAGE_F_SECOND. We still use them for 64k. I guess you should move this hunk to second patch. -aneesh
[toc] | [next] | [standalone]
| From | Ram Pai <linuxram@us.ibm.com> |
|---|---|
| Date | 2017-07-21 00:10 +0200 |
| Subject | Re: [RFC v6 01/62] powerpc: Free up four 64K PTE bits in 4K backed HPTE pages |
| Message-ID | <u5rNU-4NL-9@gated-at.bofh.it> |
| In reply to | #1692458 |
On Thu, Jul 20, 2017 at 11:21:51AM +0530, Aneesh Kumar K.V wrote: > > ..... > > > /* > > @@ -116,8 +104,8 @@ int __hash_page_4K(unsigned long ea, unsigned long access, unsigned long vsid, > > * On hash insert failure we use old pte value and we don't > > * want slot information there if we have a insert failure. > > */ > > - old_pte &= ~(H_PAGE_HASHPTE | H_PAGE_F_GIX | H_PAGE_F_SECOND); > > - new_pte &= ~(H_PAGE_HASHPTE | H_PAGE_F_GIX | H_PAGE_F_SECOND); > > + old_pte &= ~(H_PAGE_HASHPTE); > > + new_pte &= ~(H_PAGE_HASHPTE); > > goto htab_insert_hpte; > > } > > With the current path order and above hunk we will breaks the bisect I guess. With the above, when > we convert a 64k hpte to 4khpte, since this is the first patch, we > should clear that H_PAGE_F_GIX and H_PAGE_F_SECOND. We still use them > for 64k. I guess you should move this hunk to second patch. true. it should move to the next patch. Will fix it. RP
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web