Re: [RFC v6 01/62] powerpc: Free up four 64K PTE bits in 4K backed HPTE pages

From	Ram Pai <linuxram@us.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC v6 01/62] powerpc: Free up four 64K PTE bits in 4K backed HPTE pages
Date	2017-07-21 00:10 +0200
Message-ID	<u5rNU-4NL-9@gated-at.bofh.it> (permalink)
References	<u3ISR-1St-3@gated-at.bofh.it> <u3Jcd-2ea-9@gated-at.bofh.it> <u5cFg-2W0-63@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 20, 2017 at 11:21:51AM +0530, Aneesh Kumar K.V wrote:
> 
> .....
> 
> >  	/*
> > @@ -116,8 +104,8 @@ int __hash_page_4K(unsigned long ea, unsigned long access, unsigned long vsid,
> >  		 * On hash insert failure we use old pte value and we don't
> >  		 * want slot information there if we have a insert failure.
> >  		 */
> > -		old_pte &= ~(H_PAGE_HASHPTE | H_PAGE_F_GIX | H_PAGE_F_SECOND);
> > -		new_pte &= ~(H_PAGE_HASHPTE | H_PAGE_F_GIX | H_PAGE_F_SECOND);
> > +		old_pte &= ~(H_PAGE_HASHPTE);
> > +		new_pte &= ~(H_PAGE_HASHPTE);
> >  		goto htab_insert_hpte;
> >  	}
> 
> With the current path order and above hunk we will breaks the bisect I guess. With the above, when
> we convert a 64k hpte to 4khpte, since this is the first patch, we
> should clear that H_PAGE_F_GIX and H_PAGE_F_SECOND. We still use them
> for 64k. I guess you should move this hunk to second patch.

true. it should move to the next patch. Will fix it.
RP

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v6 01/62] powerpc: Free up four 64K PTE bits in 4K backed HPTE pages "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2017-07-20 08:00 +0200
  Re: [RFC v6 01/62] powerpc: Free up four 64K PTE bits in 4K backed  HPTE pages Ram Pai <linuxram@us.ibm.com> - 2017-07-21 00:10 +0200

csiph-web