Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689764 > unrolled thread

[PATCH V3 1/5] drivers/fmc: remove unused variable

Back to article view | Back to linux.kernel

Contents

  [PATCH V3 1/5] drivers/fmc: remove unused variable Alessandro Rubini <rubini@gnudd.com> - 2017-07-18 08:40 +0200
    Re: [PATCH V3 1/5] drivers/fmc: remove unused variable Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 09:00 +0200
      Re: [PATCH V3 1/5] drivers/fmc: remove unused variable Alessandro Rubini <rubini@gnudd.com> - 2017-07-18 09:10 +0200
        Re: [PATCH V3 1/5] drivers/fmc: remove unused variable Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 09:30 +0200
          Re: [PATCH V3 1/5] drivers/fmc: remove unused variable Alessandro Rubini <rubini@gnudd.com> - 2017-07-18 09:40 +0200

#1689764 — [PATCH V3 1/5] drivers/fmc: remove unused variable

From: Federico Vaga <federico.vaga@cern.ch>

Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Tested-by: Pat Riehecky <riehecky@fnal.gov>
Acked-by: Alessandro Rubini <rubini@gnudd.com>
---

V3 (Alessandro): fixed From line in patch, added alessandro's acked-by

V2 (Pat): added Tested-by and incorrect From line

V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.

 drivers/fmc/fru-parse.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/fmc/fru-parse.c b/drivers/fmc/fru-parse.c
index cb46263..eb21480 100644
--- a/drivers/fmc/fru-parse.c
+++ b/drivers/fmc/fru-parse.c
@@ -31,12 +31,11 @@ static char *__fru_alloc_get_tl(struct fru_common_header *header, int nr)
 {
 	struct fru_type_length *tl;
 	char *res;
-	int len;
 
 	tl = __fru_get_board_tl(header, nr);
 	if (!tl)
 		return NULL;
-	len = fru_strlen(tl);
+
 	res = fru_alloc(fru_strlen(tl) + 1);
 	if (!res)
 		return NULL;
-- 
2.1.4

[toc] | [next] | [standalone]

#1689789

On Tue, Jul 18, 2017 at 08:32:42AM +0200, Alessandro Rubini wrote:
> From: Federico Vaga <federico.vaga@cern.ch>
> 
> Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
> Tested-by: Pat Riehecky <riehecky@fnal.gov>
> Acked-by: Alessandro Rubini <rubini@gnudd.com>
> ---

Again, I do not like to take patches without any changelog text at all
:(

[toc] | [prev] | [next] | [standalone]

#1689790

> Again, I do not like to take patches without any changelog text at all
> :(

Sorry, I added this after the "---" line. I thought it was this one the
missing item:

 V3 (Alessandro): fixed From line in patch, added alessandro's acked-by

 V2 (Pat): added Tested-by and incorrect From line

 V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.

thanks
/alessandro

[toc] | [prev] | [next] | [standalone]

#1689814

On Tue, Jul 18, 2017 at 09:00:29AM +0200, Alessandro Rubini wrote:
> > Again, I do not like to take patches without any changelog text at all
> > :(
> 
> Sorry, I added this after the "---" line. I thought it was this one the
> missing item:
> 
>  V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
> 
>  V2 (Pat): added Tested-by and incorrect From line
> 
>  V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.

Ah, sorry, wrong "changelog".  I meant the area that shows up in git
about what this patch does.  There's no description of it other than the
Subject line.  While this is a simple patch, it is always good to say
something like "variable foo was set but never actually used, so it's
safe to remove it as the function it called did not change the hardware
state" or something like that.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1689827

> Ah, sorry, wrong "changelog".  I meant the area that shows up in git
> about what this patch does.  There's no description of it other than the
> Subject line.

Yes.  Ok, I'll add a longer commit message for V4 of the whole
set. Tomorrow (/me leaving now to a client).

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web