Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689814

Re: [PATCH V3 1/5] drivers/fmc: remove unused variable

Show all headers | View raw

On Tue, Jul 18, 2017 at 09:00:29AM +0200, Alessandro Rubini wrote:
> > Again, I do not like to take patches without any changelog text at all
> > :(
> 
> Sorry, I added this after the "---" line. I thought it was this one the
> missing item:
> 
>  V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
> 
>  V2 (Pat): added Tested-by and incorrect From line
> 
>  V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.

Ah, sorry, wrong "changelog".  I meant the area that shows up in git
about what this patch does.  There's no description of it other than the
Subject line.  While this is a simple patch, it is always good to say
something like "variable foo was set but never actually used, so it's
safe to remove it as the function it called did not change the hardware
state" or something like that.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 1/5] drivers/fmc: remove unused variable Alessandro Rubini <rubini@gnudd.com> - 2017-07-18 08:40 +0200
  Re: [PATCH V3 1/5] drivers/fmc: remove unused variable Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 09:00 +0200
    Re: [PATCH V3 1/5] drivers/fmc: remove unused variable Alessandro Rubini <rubini@gnudd.com> - 2017-07-18 09:10 +0200
      Re: [PATCH V3 1/5] drivers/fmc: remove unused variable Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 09:30 +0200
        Re: [PATCH V3 1/5] drivers/fmc: remove unused variable Alessandro Rubini <rubini@gnudd.com> - 2017-07-18 09:40 +0200

csiph-web