Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681447 > unrolled thread

Re: [PATCH 0/5] Update kernel to latest FMC bus release

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0/5] Update kernel to latest FMC bus release Alessandro Rubini <rubini@gnudd.com> - 2017-07-05 12:40 +0200
    Re: [PATCH v2 01/05] drivers/fmc: remove unused variable Greg KH <gregkh@linuxfoundation.org> - 2017-07-17 16:30 +0200
    Re: [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on  registration Alessandro Rubini <rubini@gnudd.com> - 2017-07-17 16:40 +0200
    Re: [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on  registration Greg KH <gregkh@linuxfoundation.org> - 2017-07-17 16:40 +0200

#1681447 — Re: [PATCH 0/5] Update kernel to latest FMC bus release

Hello.

Thank you Pat for taking care of these patches.

> Federico Vaga (5):
>   drivers/fmc: remove unused variable
>   drivers/fmc: hide fmc operations behind helpers
>   drivers/fmc: The only way to dump the SDB is from debugfs
>   drivers/fmc: change registration prototype
>   drivers/fmc: carrier can program FPGA on registration

The main problem with your patches, as submitted, is that they miss
the "From:" line to attribute Federico as author.  Then I think you
might add your own "Tested-by:".

I want to ack them but I'd love to run them first to have a second
check.  I should definitely manage it in a pair of days
more. Meanwhile, if you want to post V2 with the fixes above that
would be great. If needed, you can write me offlist.

thankyou for your submission and your patience
/alessandro

[toc] | [next] | [standalone]

#1689105 — Re: [PATCH v2 01/05] drivers/fmc: remove unused variable

On Wed, Jul 05, 2017 at 09:22:06AM -0500, Pat Riehecky wrote:
> From: Federico Vaga <federico.vaga@cern.ch>
> Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
> Tested-by: Pat Riehecky <riehecky@fnal.gov>
> ---
>  drivers/fmc/fru-parse.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I will not accept patches with no changelog comments, sorry.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1689126 — Re: [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on registration

> This is not how the "From:" line works, please read SubmittingPatches
> for the correct usage...

I'm submitting V3 with the correct From line, and my acked-by, since
now I managed to actually test them. It will happen later today.

Thanks greg for considering the patches.

/alessandro

[toc] | [prev] | [next] | [standalone]

#1689127 — Re: [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on registration

On Wed, Jul 05, 2017 at 09:22:10AM -0500, Pat Riehecky wrote:
> The initial FPGA may require programming before it is useful.
> 
> From: Federico Vaga <federico.vaga@cern.ch>
> Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
> Tested-by: Pat Riehecky <riehecky@fnal.gov>
> ---

This is not how the "From:" line works, please read SubmittingPatches
for the correct usage...

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web