Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681447

Re: [PATCH 0/5] Update kernel to latest FMC bus release

Show all headers | View raw

Hello.

Thank you Pat for taking care of these patches.

> Federico Vaga (5):
>   drivers/fmc: remove unused variable
>   drivers/fmc: hide fmc operations behind helpers
>   drivers/fmc: The only way to dump the SDB is from debugfs
>   drivers/fmc: change registration prototype
>   drivers/fmc: carrier can program FPGA on registration

The main problem with your patches, as submitted, is that they miss
the "From:" line to attribute Federico as author.  Then I think you
might add your own "Tested-by:".

I want to ack them but I'd love to run them first to have a second
check.  I should definitely manage it in a pair of days
more. Meanwhile, if you want to post V2 with the fixes above that
would be great. If needed, you can write me offlist.

thankyou for your submission and your patience
/alessandro

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0/5] Update kernel to latest FMC bus release Alessandro Rubini <rubini@gnudd.com> - 2017-07-05 12:40 +0200
  Re: [PATCH v2 01/05] drivers/fmc: remove unused variable Greg KH <gregkh@linuxfoundation.org> - 2017-07-17 16:30 +0200
  Re: [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on  registration Alessandro Rubini <rubini@gnudd.com> - 2017-07-17 16:40 +0200
  Re: [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on  registration Greg KH <gregkh@linuxfoundation.org> - 2017-07-17 16:40 +0200

csiph-web