Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690933 > unrolled thread
| Started by | Joseph Wright <rjosephwright@gmail.com> |
|---|---|
| First post | 2017-07-19 05:10 +0200 |
| Last post | 2017-07-20 13:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] Staging: pi433: fix sparse warnings Joseph Wright <rjosephwright@gmail.com> - 2017-07-19 05:10 +0200
[PATCH 1/2] Staging: pi433: declare functions static Joseph Wright <rjosephwright@gmail.com> - 2017-07-19 05:10 +0200
Re: [PATCH 1/2] Staging: pi433: declare functions static "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de> - 2017-07-20 13:10 +0200
| From | Joseph Wright <rjosephwright@gmail.com> |
|---|---|
| Date | 2017-07-19 05:10 +0200 |
| Subject | [PATCH 0/2] Staging: pi433: fix sparse warnings |
| Message-ID | <u4Nx7-2EI-3@gated-at.bofh.it> |
Two patches included to fix warnings found with sparse. Joseph Wright (2): Staging: pi433: declare functions static Staging: pi433: check error after kthread_run() drivers/staging/pi433/pi433_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.9.3
[toc] | [next] | [standalone]
| From | Joseph Wright <rjosephwright@gmail.com> |
|---|---|
| Date | 2017-07-19 05:10 +0200 |
| Subject | [PATCH 1/2] Staging: pi433: declare functions static |
| Message-ID | <u4Nx7-2EI-7@gated-at.bofh.it> |
| In reply to | #1690933 |
Declare functions static to fix sparse warnings:
warning: symbol 'pi433_receive' was not declared. Should it be static?
warning: symbol 'pi433_tx_thread' was not declared. Should it be static?
Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 1bc478a..46461b4 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -313,7 +313,7 @@ pi433_start_rx(struct pi433_device *dev)
/*-------------------------------------------------------------------------*/
-int
+static int
pi433_receive(void *data)
{
struct pi433_device *dev = data;
@@ -463,7 +463,7 @@ pi433_receive(void *data)
return bytes_total;
}
-int
+static int
pi433_tx_thread(void *data)
{
struct pi433_device *device = data;
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de> |
|---|---|
| Date | 2017-07-20 13:10 +0200 |
| Subject | Re: [PATCH 1/2] Staging: pi433: declare functions static |
| Message-ID | <u5hvd-6vT-15@gated-at.bofh.it> |
| In reply to | #1690935 |
Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Am So, 16.07.2017, 16:48 schrieb Joseph Wright:
> Declare functions static to fix sparse warnings:
>
> warning: symbol 'pi433_receive' was not declared. Should it be static?
> warning: symbol 'pi433_tx_thread' was not declared. Should it be static?
>
> Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 1bc478a..46461b4 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -313,7 +313,7 @@ pi433_start_rx(struct pi433_device *dev)
>
> /*-------------------------------------------------------------------------*/
>
> -int
> +static int
> pi433_receive(void *data)
> {
> struct pi433_device *dev = data;
> @@ -463,7 +463,7 @@ pi433_receive(void *data)
> return bytes_total;
> }
>
> -int
> +static int
> pi433_tx_thread(void *data)
> {
> struct pi433_device *device = data;
> --
> 2.9.3
>
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web