Re: [PATCH 1/2] Staging: pi433: declare functions static

From	"Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Staging: pi433: declare functions static
Date	2017-07-20 13:10 +0200
Message-ID	<u5hvd-6vT-15@gated-at.bofh.it> (permalink)
References	<u4Nx7-2EI-3@gated-at.bofh.it> <u4Nx7-2EI-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>

Am So, 16.07.2017, 16:48 schrieb Joseph Wright:
> Declare functions static to fix sparse warnings:
>
> warning: symbol 'pi433_receive' was not declared. Should it be static?
> warning: symbol 'pi433_tx_thread' was not declared. Should it be static?
>
> Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 1bc478a..46461b4 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -313,7 +313,7 @@ pi433_start_rx(struct pi433_device *dev)
>
>  /*-------------------------------------------------------------------------*/
>
> -int
> +static int
>  pi433_receive(void *data)
>  {
>  	struct pi433_device *dev = data;
> @@ -463,7 +463,7 @@ pi433_receive(void *data)
>  		return bytes_total;
>  }
>
> -int
> +static int
>  pi433_tx_thread(void *data)
>  {
>  	struct pi433_device *device = data;
> --
> 2.9.3
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Staging: pi433: fix sparse warnings Joseph Wright <rjosephwright@gmail.com> - 2017-07-19 05:10 +0200
  [PATCH 1/2] Staging: pi433: declare functions static Joseph Wright <rjosephwright@gmail.com> - 2017-07-19 05:10 +0200
    Re: [PATCH 1/2] Staging: pi433: declare functions static "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de> - 2017-07-20 13:10 +0200

csiph-web