Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690470 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-07-18 19:10 +0200 |
| Last post | 2017-07-18 20:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: hda: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-18 19:10 +0200
Re: [PATCH] ALSA: hda: constify pci_device_id. Takashi Iwai <tiwai@suse.de> - 2017-07-18 20:10 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-07-18 19:10 +0200 |
| Subject | [PATCH] ALSA: hda: constify pci_device_id. |
| Message-ID | <u4Eav-5aT-31@gated-at.bofh.it> |
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2610 304 8 2922 b6a sound/hda/hdac_i915.o
File size After adding 'const':
text data bss dec hex filename
2674 240 8 2922 b6a sound/hda/hdac_i915.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/hda/hdac_i915.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
index 0659bf3..038a180 100644
--- a/sound/hda/hdac_i915.c
+++ b/sound/hda/hdac_i915.c
@@ -336,7 +336,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_i915_register_notifier);
/* check whether intel graphics is present */
static bool i915_gfx_present(void)
{
- static struct pci_device_id ids[] = {
+ static const struct pci_device_id ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID),
.class = PCI_BASE_CLASS_DISPLAY << 16,
.class_mask = 0xff << 16 },
--
2.7.4
[toc] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2017-07-18 20:10 +0200 |
| Message-ID | <u4F6y-5Lu-3@gated-at.bofh.it> |
| In reply to | #1690470 |
On Tue, 18 Jul 2017 19:05:06 +0200, Arvind Yadav wrote: > > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by <linux/pci.h> work with > const pci_device_id. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2610 304 8 2922 b6a sound/hda/hdac_i915.o > > File size After adding 'const': > text data bss dec hex filename > 2674 240 8 2922 b6a sound/hda/hdac_i915.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied, thanks. Takashi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web