Re: [PATCH] ALSA: hda: constify pci_device_id.

From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ALSA: hda: constify pci_device_id.
Date	2017-07-18 20:10 +0200
Message-ID	<u4F6y-5Lu-3@gated-at.bofh.it> (permalink)
References	<u4Eav-5aT-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 18 Jul 2017 19:05:06 +0200,
Arvind Yadav wrote:
> 
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    2610	    304	      8	   2922	    b6a	sound/hda/hdac_i915.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    2674	    240	      8	   2922	    b6a	sound/hda/hdac_i915.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied, thanks.


Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: hda: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-18 19:10 +0200
  Re: [PATCH] ALSA: hda: constify pci_device_id. Takashi Iwai <tiwai@suse.de> - 2017-07-18 20:10 +0200

csiph-web