Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690317 > unrolled thread

Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch Arnd Bergmann <arnd@arndb.de> - 2017-07-18 16:30 +0200
    Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile  multi-arch Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-07-18 16:40 +0200
      Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch Arnd Bergmann <arnd@arndb.de> - 2017-07-18 16:40 +0200

#1690317 — Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

On Tue, Jul 18, 2017 at 3:37 PM,  <laurentiu.tudor@nxp.com> wrote:

> --- a/drivers/staging/fsl-dpaa2/Kconfig
> +++ b/drivers/staging/fsl-dpaa2/Kconfig
> @@ -4,7 +4,7 @@
>
>  config FSL_DPAA2
>         bool "Freescale DPAA2 devices"
> -       depends on FSL_MC_BUS
> +       depends on FSL_MC_BUS && ARCH_LAYERSCAPE
>         ---help---
>           Build drivers for Freescale DataPath Acceleration
>           Architecture (DPAA2) family of SoCs.

I would probably leave the dependency in there conditionally, like

         depends on ARCH_LAYERSCAPE || COMPILE_TEST

That way, we can build the driver on all architectures with "make allmodconfig"
or "make randconfig", but regular users that disable COMPILE_TEST
won't be bothered by the extra config options unless they have the
right hardware.

       Arnd

[toc] | [next] | [standalone]

#1690325 — Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

Hi Arnd,

On 07/18/2017 05:25 PM, Arnd Bergmann wrote:
> On Tue, Jul 18, 2017 at 3:37 PM,  <laurentiu.tudor@nxp.com> wrote:
>
>> --- a/drivers/staging/fsl-dpaa2/Kconfig
>> +++ b/drivers/staging/fsl-dpaa2/Kconfig
>> @@ -4,7 +4,7 @@
>>
>>   config FSL_DPAA2
>>          bool "Freescale DPAA2 devices"
>> -       depends on FSL_MC_BUS
>> +       depends on FSL_MC_BUS && ARCH_LAYERSCAPE
>>          ---help---
>>            Build drivers for Freescale DataPath Acceleration
>>            Architecture (DPAA2) family of SoCs.
>
> I would probably leave the dependency in there conditionally, like
>
>           depends on ARCH_LAYERSCAPE || COMPILE_TEST
>
> That way, we can build the driver on all architectures with "make allmodconfig"
> or "make randconfig", but regular users that disable COMPILE_TEST
> won't be bothered by the extra config options unless they have the
> right hardware.
>

Good point, I'll take care of it. But don't you mean COMPILE_TEST be 
added on the actual MC_BUS config, like so:

  config FSL_MC_BUS
  	bool "QorIQ DPAA2 fsl-mc bus driver"
-	depends on OF && ARCH_LAYERSCAPE
+	depends on OF && (ARCH_LAYERSCAPE || COMPILE_TEST)
  	select GENERIC_MSI_IRQ_DOMAIN
?

The other drivers that depend on the MC_BUS won't compile on other 
architectures.

---
Thanks & Best Regards, Laurentiu

[toc] | [prev] | [next] | [standalone]

#1690329

On Tue, Jul 18, 2017 at 4:36 PM, Laurentiu Tudor
<laurentiu.tudor@nxp.com> wrote:

> Good point, I'll take care of it. But don't you mean COMPILE_TEST be
> added on the actual MC_BUS config, like so:
>
>   config FSL_MC_BUS
>         bool "QorIQ DPAA2 fsl-mc bus driver"
> -       depends on OF && ARCH_LAYERSCAPE
> +       depends on OF && (ARCH_LAYERSCAPE || COMPILE_TEST)
>         select GENERIC_MSI_IRQ_DOMAIN
> ?
>
> The other drivers that depend on the MC_BUS won't compile on other
> architectures.

I was thinking of adding it to all three, but you are right we only needed
it for the bus.

        Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web