Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch
Date	2017-07-18 16:30 +0200
Message-ID	<u4BFE-3wF-27@gated-at.bofh.it> (permalink)
References	<u4BvZ-3ta-43@gated-at.bofh.it> <u4BFE-3wF-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 18, 2017 at 3:37 PM,  <laurentiu.tudor@nxp.com> wrote:

> --- a/drivers/staging/fsl-dpaa2/Kconfig
> +++ b/drivers/staging/fsl-dpaa2/Kconfig
> @@ -4,7 +4,7 @@
>
>  config FSL_DPAA2
>         bool "Freescale DPAA2 devices"
> -       depends on FSL_MC_BUS
> +       depends on FSL_MC_BUS && ARCH_LAYERSCAPE
>         ---help---
>           Build drivers for Freescale DataPath Acceleration
>           Architecture (DPAA2) family of SoCs.

I would probably leave the dependency in there conditionally, like

         depends on ARCH_LAYERSCAPE || COMPILE_TEST

That way, we can build the driver on all architectures with "make allmodconfig"
or "make randconfig", but regular users that disable COMPILE_TEST
won't be bothered by the extra config options unless they have the
right hardware.

       Arnd

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch Arnd Bergmann <arnd@arndb.de> - 2017-07-18 16:30 +0200
  Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile  multi-arch Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-07-18 16:40 +0200
    Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch Arnd Bergmann <arnd@arndb.de> - 2017-07-18 16:40 +0200

csiph-web