Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690245 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-07-18 15:10 +0200 |
| Last post | 2017-07-20 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check Colin King <colin.king@canonical.com> - 2017-07-18 15:10 +0200
Re: [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de> - 2017-07-20 13:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-07-18 15:10 +0200 |
| Subject | [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check |
| Message-ID | <u4Aqd-2Pp-5@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The check for thread_run failure is incorrect, use IS_ERR instead.
Cleans up sparse error message:
"error: incompatible types for operation (<)"
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/pi433/pi433_if.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 95930a192de4..266e572ae66e 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -1152,8 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
device->tx_task_struct = kthread_run(pi433_tx_thread,
device,
"pi433_tx_task");
- if (device->tx_task_struct < 0)
- {
+ if (IS_ERR(device->tx_task_struct)) {
dev_dbg(device->dev, "start of send thread failed");
goto send_thread_failed;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de> |
|---|---|
| Date | 2017-07-20 13:10 +0200 |
| Subject | Re: [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check |
| Message-ID | <u5hvd-6vT-13@gated-at.bofh.it> |
| In reply to | #1690245 |
Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Tested-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Am Di, 18.07.2017, 15:04 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for thread_run failure is incorrect, use IS_ERR instead.
>
> Cleans up sparse error message:
> "error: incompatible types for operation (<)"
>
> Fixes: 874bcba65f9a ("staging: pi433: New driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/pi433/pi433_if.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 95930a192de4..266e572ae66e 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -1152,8 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
> device->tx_task_struct = kthread_run(pi433_tx_thread,
> device,
> "pi433_tx_task");
> - if (device->tx_task_struct < 0)
> - {
> + if (IS_ERR(device->tx_task_struct)) {
> dev_dbg(device->dev, "start of send thread failed");
> goto send_thread_failed;
> }
> --
> 2.11.0
>
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web