Re: [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check

From	"Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check
Date	2017-07-20 13:10 +0200
Message-ID	<u5hvd-6vT-13@gated-at.bofh.it> (permalink)
References	<u4Aqd-2Pp-7@gated-at.bofh.it> <u4Aqd-2Pp-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
Tested-by: Marcus Wolf <linux@wolf-entwicklungen.de>

Am Di, 18.07.2017, 15:04 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for thread_run failure is incorrect, use IS_ERR instead.
>
> Cleans up sparse error message:
> "error: incompatible types for operation (<)"
>
> Fixes: 874bcba65f9a ("staging: pi433: New driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 95930a192de4..266e572ae66e 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -1152,8 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
>  	device->tx_task_struct = kthread_run(pi433_tx_thread,
>  					     device,
>  					     "pi433_tx_task");
> -	if (device->tx_task_struct < 0)
> -	{
> +	if (IS_ERR(device->tx_task_struct)) {
>  		dev_dbg(device->dev, "start of send thread failed");
>  		goto send_thread_failed;
>  	}
> --
> 2.11.0
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check Colin King <colin.king@canonical.com> - 2017-07-18 15:10 +0200
  Re: [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure  check "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de> - 2017-07-20 13:10 +0200

csiph-web