Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681239 > unrolled thread

[PATCH] Staging: android/ion: fix sparse warnings

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: android/ion: fix sparse warnings Joseph Wright <rjosephwright@gmail.com> - 2017-07-05 03:50 +0200
    Re: [PATCH] Staging: android/ion: fix sparse warnings Greg KH <gregkh@linuxfoundation.org> - 2017-07-11 20:10 +0200

#1681239 — [PATCH] Staging: android/ion: fix sparse warnings

ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
	was not declared. Should it be static?
ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
	was not declared. Should it be static?
ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
	was not declared. Should it be static?

Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
---
 drivers/staging/android/ion/ion.h          | 4 ++++
 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
index fa9ed81..fda1e91 100644
--- a/drivers/staging/android/ion/ion.h
+++ b/drivers/staging/android/ion/ion.h
@@ -358,4 +358,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
 
 int ion_query_heaps(struct ion_heap_query *query);
 
+struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data);
+
+struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data);
+
 #endif /* _ION_H */
diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc..c6db9b7 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
 	return &cma_heap->heap;
 }
 
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
 {
 	struct ion_heap *heap;
 
-- 
2.9.3

[toc] | [next] | [standalone]

#1685265

On Wed, Jul 05, 2017 at 12:12:24AM +0000, Joseph Wright wrote:
> ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
> 	was not declared. Should it be static?
> ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
> 	was not declared. Should it be static?
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> 	was not declared. Should it be static?

You are doing two different types of things here, please break this up
into multiple patches.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web