Re: [PATCH] Staging: android/ion: fix sparse warnings

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: android/ion: fix sparse warnings
Date	2017-07-11 20:10 +0200
Message-ID	<u27LI-5Eg-9@gated-at.bofh.it> (permalink)
References	<tZHC5-7VG-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 05, 2017 at 12:12:24AM +0000, Joseph Wright wrote:
> ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
> 	was not declared. Should it be static?
> ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
> 	was not declared. Should it be static?
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> 	was not declared. Should it be static?

You are doing two different types of things here, please break this up
into multiple patches.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: android/ion: fix sparse warnings Joseph Wright <rjosephwright@gmail.com> - 2017-07-05 03:50 +0200
  Re: [PATCH] Staging: android/ion: fix sparse warnings Greg KH <gregkh@linuxfoundation.org> - 2017-07-11 20:10 +0200

csiph-web