Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684917 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-07-11 11:30 +0200 |
| Last post | 2017-07-11 21:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] PCI: hotplug: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 11:30 +0200
Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures. Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-07-11 21:00 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-07-11 11:30 +0200 |
| Subject | [PATCH 3/3] PCI: hotplug: constify attribute_group structures. |
| Message-ID | <u1ZEu-sY-5@gated-at.bofh.it> |
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o
File size After adding 'const':
text data bss dec hex filename
482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c b/drivers/pci/hotplug/rpadlpar_sysfs.c
index a796301..edb5d8a 100644
--- a/drivers/pci/hotplug/rpadlpar_sysfs.c
+++ b/drivers/pci/hotplug/rpadlpar_sysfs.c
@@ -102,7 +102,7 @@ static ssize_t remove_slot_show(struct kobject *kobj,
NULL,
};
-static struct attribute_group dlpar_attr_group = {
+static const struct attribute_group dlpar_attr_group = {
.attrs = default_attrs,
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Tyrel Datwyler <tyreld@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-07-11 21:00 +0200 |
| Message-ID | <u28y5-5YV-3@gated-at.bofh.it> |
| In reply to | #1684917 |
On 07/11/2017 02:28 AM, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by <linux/sysfs.h> work > with const attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 418 160 8 586 24a drivers/pci/hotplug/rpadlpar_sysfs.o > > File size After adding 'const': > text data bss dec hex filename > 482 96 8 586 232 drivers/pci/hotplug/rpadlpar_sysfs.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web