Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures.

From	Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures.
Date	2017-07-11 21:00 +0200
Message-ID	<u28y5-5YV-3@gated-at.bofh.it> (permalink)
References	<u1ZEu-sY-7@gated-at.bofh.it> <u1ZEu-sY-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/11/2017 02:28 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>     418	    160	      8	    586	    24a	drivers/pci/hotplug/rpadlpar_sysfs.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>     482	     96	      8	    586	    232	drivers/pci/hotplug/rpadlpar_sysfs.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] PCI: hotplug: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 11:30 +0200
  Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures. Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-07-11 21:00 +0200

csiph-web