Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1681289 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-07-05 07:50 +0200 |
| Last post | 2017-07-10 19:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] hwtracing: coresight: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-05 07:50 +0200
Re: [PATCH] hwtracing: coresight: constify attribute_group structures. Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-07-07 17:30 +0200
Re: [PATCH] hwtracing: coresight: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-10 07:20 +0200
Re: [PATCH] hwtracing: coresight: constify attribute_group structures. Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-07-10 19:10 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-07-05 07:50 +0200 |
| Subject | [PATCH] hwtracing: coresight: constify attribute_group structures. |
| Message-ID | <tZLmh-27Q-5@gated-at.bofh.it> |
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2573 288 296 3157 c55 coresight-etm-perf.o
File size After adding 'const':
text data bss dec hex filename
2613 224 296 3133 c3d coresight-etm-perf.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 288a423..e97775d 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -60,7 +60,7 @@ struct etm_event_data {
NULL,
};
-static struct attribute_group etm_pmu_format_group = {
+static const struct attribute_group etm_pmu_format_group = {
.name = "format",
.attrs = etm_config_formats_attr,
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Mathieu Poirier <mathieu.poirier@linaro.org> |
|---|---|
| Date | 2017-07-07 17:30 +0200 |
| Message-ID | <u0DmG-5Qq-11@gated-at.bofh.it> |
| In reply to | #1681289 |
On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2573 288 296 3157 c55 coresight-etm-perf.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2613 224 296 3133 c3d coresight-etm-perf.o
Hi Arvind,
Did you find this using an automated tool or simply stumbled on it
while reviewing the code? In case of the former it is usually a good
idea to specify which tool was used in the change log.
Thanks,
Mathieu
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 288a423..e97775d 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -60,7 +60,7 @@ struct etm_event_data {
> NULL,
> };
>
> -static struct attribute_group etm_pmu_format_group = {
> +static const struct attribute_group etm_pmu_format_group = {
> .name = "format",
> .attrs = etm_config_formats_attr,
> };
> --
> 1.9.1
>
[toc] | [prev] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-07-10 07:20 +0200 |
| Subject | Re: [PATCH] hwtracing: coresight: constify attribute_group structures. |
| Message-ID | <u1zgZ-N7-1@gated-at.bofh.it> |
| In reply to | #1683253 |
Hi Mathieu,
On Friday 07 July 2017 08:58 PM, Mathieu Poirier wrote:
> On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>> attribute_groups are not supposed to change at runtime. All functions
>> working with attribute_groups provided by <linux/sysfs.h> work with const
>> attribute_group. So mark the non-const structs as const.
>>
>> File size before:
>> text data bss dec hex filename
>> 2573 288 296 3157 c55 coresight-etm-perf.o
>>
>> File size After adding 'const':
>> text data bss dec hex filename
>> 2613 224 296 3133 c3d coresight-etm-perf.o
> Hi Arvind,
>
> Did you find this using an automated tool or simply stumbled on it
> while reviewing the code? In case of the former it is usually a good
> idea to specify which tool was used in the change log.
Automated tools are not able to caught this kind of error.
I have fixed same changes in zram ( commit - dfc8ed8d6a).
Minchan Kim suggested me to change all the places where have not
used const. It's good idea have a tool which can able to detect these
kind of error. I will try to create a tool.
>
> Thanks,
> Mathieu
>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
>> index 288a423..e97775d 100644
>> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
>> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
>> @@ -60,7 +60,7 @@ struct etm_event_data {
>> NULL,
>> };
>>
>> -static struct attribute_group etm_pmu_format_group = {
>> +static const struct attribute_group etm_pmu_format_group = {
>> .name = "format",
>> .attrs = etm_config_formats_attr,
>> };
>> --
>> 1.9.1
>>
Thanks,
~arvind
[toc] | [prev] | [next] | [standalone]
| From | Mathieu Poirier <mathieu.poirier@linaro.org> |
|---|---|
| Date | 2017-07-10 19:10 +0200 |
| Message-ID | <u1Km6-7MA-15@gated-at.bofh.it> |
| In reply to | #1681289 |
On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2573 288 296 3157 c55 coresight-etm-perf.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2613 224 296 3133 c3d coresight-etm-perf.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 288a423..e97775d 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -60,7 +60,7 @@ struct etm_event_data {
> NULL,
> };
>
> -static struct attribute_group etm_pmu_format_group = {
> +static const struct attribute_group etm_pmu_format_group = {
> .name = "format",
> .attrs = etm_config_formats_attr,
> };
> --
> 1.9.1
>
Applied - thanks.
Mathieu
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web