Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684422

Re: [PATCH] hwtracing: coresight: constify attribute_group structures.

Show all headers | View raw

On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
>   text     data     bss     dec     hex filename
>    2573     288     296    3157     c55 coresight-etm-perf.o
>
> File size After adding 'const':
>    text    data     bss     dec     hex filename
>    2613     224     296    3133     c3d coresight-etm-perf.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 288a423..e97775d 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -60,7 +60,7 @@ struct etm_event_data {
>         NULL,
>  };
>
> -static struct attribute_group etm_pmu_format_group = {
> +static const struct attribute_group etm_pmu_format_group = {
>         .name   = "format",
>         .attrs  = etm_config_formats_attr,
>  };
> --
> 1.9.1
>

Applied - thanks.
Mathieu

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] hwtracing: coresight: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-05 07:50 +0200
  Re: [PATCH] hwtracing: coresight: constify attribute_group structures. Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-07-07 17:30 +0200
    Re: [PATCH] hwtracing: coresight: constify attribute_group  structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-10 07:20 +0200
  Re: [PATCH] hwtracing: coresight: constify attribute_group structures. Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-07-10 19:10 +0200

csiph-web