Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1682081 > unrolled thread
| Started by | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| First post | 2017-07-06 08:50 +0200 |
| Last post | 2017-07-06 12:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Stephen Boyd <sboyd@codeaurora.org> - 2017-07-06 08:50 +0200
Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability kgunda@codeaurora.org - 2017-07-06 12:40 +0200
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2017-07-06 08:50 +0200 |
| Subject | Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability |
| Message-ID | <u08LU-OV-15@gated-at.bofh.it> |
On 07/03, Kiran Gunda wrote:
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index 5285245..2d2e39c 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type)
> return 0;
> }
>
> +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on)
> +{
> + struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d);
> + int ret;
> +
> + if (on)
> + ret = enable_irq_wake(pmic_arb->irq);
> + else
> + ret = disable_irq_wake(pmic_arb->irq);
Could be simplified to
return irq_set_irq_wake(pmic_arb->irq, on);
?
> +
> + return ret;
> +}
> +
> static int qpnpint_get_irqchip_state(struct irq_data *d,
> enum irqchip_irq_state which,
> bool *state)
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [next] | [standalone]
| From | kgunda@codeaurora.org |
|---|---|
| Date | 2017-07-06 12:40 +0200 |
| Message-ID | <u0cmt-35v-5@gated-at.bofh.it> |
| In reply to | #1682081 |
On 2017-07-06 12:16, Stephen Boyd wrote:
> On 07/03, Kiran Gunda wrote:
>> diff --git a/drivers/spmi/spmi-pmic-arb.c
>> b/drivers/spmi/spmi-pmic-arb.c
>> index 5285245..2d2e39c 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data
>> *d, unsigned int flow_type)
>> return 0;
>> }
>>
>> +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on)
>> +{
>> + struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d);
>> + int ret;
>> +
>> + if (on)
>> + ret = enable_irq_wake(pmic_arb->irq);
>> + else
>> + ret = disable_irq_wake(pmic_arb->irq);
>
> Could be simplified to
>
> return irq_set_irq_wake(pmic_arb->irq, on);
>
> ?
>
yes. Will modify it.
>> +
>> + return ret;
>> +}
>> +
>> static int qpnpint_get_irqchip_state(struct irq_data *d,
>> enum irqchip_irq_state which,
>> bool *state)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web