Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682081

Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability

Show all headers | View raw

On 07/03, Kiran Gunda wrote:
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index 5285245..2d2e39c 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type)
>  	return 0;
>  }
>  
> +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on)
> +{
> +	struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d);
> +	int ret;
> +
> +	if (on)
> +		ret = enable_irq_wake(pmic_arb->irq);
> +	else
> +		ret = disable_irq_wake(pmic_arb->irq);

Could be simplified to 

	return irq_set_irq_wake(pmic_arb->irq, on);

?

> +
> +	return ret;
> +}
> +
>  static int qpnpint_get_irqchip_state(struct irq_data *d,
>  				     enum irqchip_irq_state which,
>  				     bool *state)

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi  irq wakeup capability Stephen Boyd <sboyd@codeaurora.org> - 2017-07-06 08:50 +0200
  Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi  irq wakeup capability kgunda@codeaurora.org - 2017-07-06 12:40 +0200

csiph-web