Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1629703 > unrolled thread
| Started by | Will Deacon <will.deacon@arm.com> |
|---|---|
| First post | 2017-04-24 18:00 +0200 |
| Last post | 2017-04-25 14:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] iommu: arm-smmu: correct sid to mask Will Deacon <will.deacon@arm.com> - 2017-04-24 18:00 +0200
Re: [PATCH] iommu: arm-smmu: correct sid to mask Joerg Roedel <joro@8bytes.org> - 2017-04-25 14:30 +0200
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Date | 2017-04-24 18:00 +0200 |
| Subject | Re: [PATCH] iommu: arm-smmu: correct sid to mask |
| Message-ID | <tzOz7-q9-5@gated-at.bofh.it> |
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
> }
> if (mask & ~smmu->smr_mask_mask) {
> dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> - sid, smmu->smr_mask_mask);
> + mask, smmu->smr_mask_mask);
> goto out_free;
Looks like a copy-paste error to me:
Acked-by: Will Deacon <will.deacon@arm.com>
Joerg: do you mind picking this one up, please?
Thanks,
Will
[toc] | [next] | [standalone]
| From | Joerg Roedel <joro@8bytes.org> |
|---|---|
| Date | 2017-04-25 14:30 +0200 |
| Message-ID | <tA7Ls-4EF-39@gated-at.bofh.it> |
| In reply to | #1629703 |
On Mon, Apr 24, 2017 at 04:54:54PM +0100, Will Deacon wrote: > On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote: > > - sid, smmu->smr_mask_mask); > > + mask, smmu->smr_mask_mask); > > goto out_free; > > Looks like a copy-paste error to me: > > Acked-by: Will Deacon <will.deacon@arm.com> > > Joerg: do you mind picking this one up, please? Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web