Re: [PATCH] iommu: arm-smmu: correct sid to mask

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu: arm-smmu: correct sid to mask
Date	2017-04-24 18:00 +0200
Message-ID	<tzOz7-q9-5@gated-at.bofh.it> (permalink)
References	<tzOz7-q9-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> ---
>  drivers/iommu/arm-smmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
>  		}
>  		if (mask & ~smmu->smr_mask_mask) {
>  			dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> -				sid, smmu->smr_mask_mask);
> +				mask, smmu->smr_mask_mask);
>  			goto out_free;

Looks like a copy-paste error to me:

Acked-by: Will Deacon <will.deacon@arm.com>

Joerg: do you mind picking this one up, please?

Thanks,

Will

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iommu: arm-smmu: correct sid to mask Will Deacon <will.deacon@arm.com> - 2017-04-24 18:00 +0200
  Re: [PATCH] iommu: arm-smmu: correct sid to mask Joerg Roedel <joro@8bytes.org> - 2017-04-25 14:30 +0200

csiph-web