Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628668 > unrolled thread
| Started by | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| First post | 2017-04-22 01:20 +0200 |
| Last post | 2017-04-22 01:20 +0200 |
| Articles | 14 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 0/8] Fix clean target warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
[PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
[PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
[PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:40 +0200
RE: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean David Laight <David.Laight@ACULAB.COM> - 2017-04-24 17:50 +0200
Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Shuah Khan <shuah@kernel.org> - 2017-04-24 21:50 +0200
[PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
RE: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings David Laight <David.Laight@ACULAB.COM> - 2017-04-24 18:00 +0200
Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Shuah Khan <shuah@kernel.org> - 2017-04-24 21:50 +0200
[PATCH 5/8] selftests: powerpc: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2017-04-22 01:20 +0200 |
| Subject | [PATCH 0/8] Fix clean target warnings |
| Message-ID | <tyQ0h-3xb-3@gated-at.bofh.it> |
This patch series consists of changes to lib.mk to allow overriding
common clean target from Makefiles. This fixes warnings when clean
overriding and ignoring warnings. Also fixes splice clean target
removing a script that runs the test from its clean target.
Shuah Khan (8):
selftests: splice: fix clean target to not remove
default_file_splice_read.sh
selftests: lib.mk: define CLEAN macro to allow Makefiles to override
clean
selftests: futex: override clean in lib.mk to fix warnings
selftests: gpio: override clean in lib.mk to fix warnings
selftests: powerpc: override clean in lib.mk to fix warnings
selftests: splice: override clean in lib.mk to fix warnings
selftests: sync: override clean in lib.mk to fix warnings
selftests: x86: override clean in lib.mk to fix warnings
tools/testing/selftests/futex/Makefile | 3 ++-
tools/testing/selftests/gpio/Makefile | 3 ++-
tools/testing/selftests/lib.mk | 6 +++++-
tools/testing/selftests/powerpc/Makefile | 3 ++-
tools/testing/selftests/splice/Makefile | 5 +++--
tools/testing/selftests/sync/Makefile | 3 ++-
tools/testing/selftests/x86/Makefile | 3 ++-
7 files changed, 18 insertions(+), 8 deletions(-)
--
2.9.3
[toc] | [next] | [standalone]
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2017-04-22 01:20 +0200 |
| Subject | [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings |
| Message-ID | <tyQ0i-3xb-21@gated-at.bofh.it> |
| In reply to | #1628668 |
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:8: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/splice/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile index 559512c..3f967ba 100644 --- a/tools/testing/selftests/splice/Makefile +++ b/tools/testing/selftests/splice/Makefile @@ -4,5 +4,6 @@ all: $(TEST_PROGS) $(EXTRA) include ../lib.mk -clean: +override define CLEAN rm -fr $(EXTRA) +endef -- 2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2017-04-22 07:50 +0200 |
| Subject | Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings |
| Message-ID | <tyW5H-7iV-5@gated-at.bofh.it> |
| In reply to | #1628673 |
Shuah Khan <shuahkh@osg.samsung.com> writes: > Add override for lib.mk clean to fix the following warnings from clean > target run. > > Makefile:8: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > tools/testing/selftests/splice/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile > index 559512c..3f967ba 100644 > --- a/tools/testing/selftests/splice/Makefile > +++ b/tools/testing/selftests/splice/Makefile > @@ -4,5 +4,6 @@ all: $(TEST_PROGS) $(EXTRA) > > include ../lib.mk > > -clean: > +override define CLEAN > rm -fr $(EXTRA) > +endef Could just be: EXTRA_CLEAN := $(EXTRA) cheers
[toc] | [prev] | [next] | [standalone]
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2017-04-22 01:20 +0200 |
| Subject | [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings |
| Message-ID | <tyQ0i-3xb-19@gated-at.bofh.it> |
| In reply to | #1628668 |
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:11: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/gpio/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile index 205e4d1..4f6d9e0 100644 --- a/tools/testing/selftests/gpio/Makefile +++ b/tools/testing/selftests/gpio/Makefile @@ -7,8 +7,9 @@ include ../lib.mk all: $(BINARIES) -clean: +override define CLEAN $(RM) $(BINARIES) +endef CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ LDLIBS += -lmount -I/usr/include/libmount -- 2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2017-04-22 07:50 +0200 |
| Subject | Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings |
| Message-ID | <tyW5H-7iV-3@gated-at.bofh.it> |
| In reply to | #1628675 |
Shuah Khan <shuahkh@osg.samsung.com> writes: > Add override for lib.mk clean to fix the following warnings from clean > target run. > > Makefile:11: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > tools/testing/selftests/gpio/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile > index 205e4d1..4f6d9e0 100644 > --- a/tools/testing/selftests/gpio/Makefile > +++ b/tools/testing/selftests/gpio/Makefile > @@ -7,8 +7,9 @@ include ../lib.mk > > all: $(BINARIES) > > -clean: > +override define CLEAN > $(RM) $(BINARIES) > +endef This could be achieved more simply with: EXTRA_CLEAN := $(BINARIES) cheers
[toc] | [prev] | [next] | [standalone]
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2017-04-22 01:20 +0200 |
| Subject | [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean |
| Message-ID | <tyQ0i-3xb-23@gated-at.bofh.it> |
| In reply to | #1628668 |
Define CLEAN macro to allow Makefiles to override common clean target in lib.mk. This will help fix the following failures: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/lib.mk | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 775c589..959273c 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -51,8 +51,12 @@ endef emit_tests: $(EMIT_TESTS) -clean: +define CLEAN $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) +endef + +clean: + $(CLEAN) $(OUTPUT)/%:%.c $(LINK.c) $^ $(LDLIBS) -o $@ -- 2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2017-04-22 07:40 +0200 |
| Subject | Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean |
| Message-ID | <tyVW2-7fF-7@gated-at.bofh.it> |
| In reply to | #1628676 |
Shuah Khan <shuahkh@osg.samsung.com> writes:
> Define CLEAN macro to allow Makefiles to override common clean target
> in lib.mk. This will help fix the following failures:
>
> warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Should probably have:
Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target")
In hindsight I'm not sure moving the clean target into lib.mk was
the best idea, but anyway it's a bit late to change our mind on that.
This patch is a good solution to fix the warnings.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
[toc] | [prev] | [next] | [standalone]
| From | David Laight <David.Laight@ACULAB.COM> |
|---|---|
| Date | 2017-04-24 17:50 +0200 |
| Subject | RE: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean |
| Message-ID | <tzOpt-mK-35@gated-at.bofh.it> |
| In reply to | #1628676 |
From: Shuah Khan > Sent: 22 April 2017 00:15 > Define CLEAN macro to allow Makefiles to override common clean target > in lib.mk. This will help fix the following failures: > > warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > tools/testing/selftests/lib.mk | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 775c589..959273c 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -51,8 +51,12 @@ endef > emit_tests: > $(EMIT_TESTS) > > -clean: > +define CLEAN > $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) > +endef > + > +clean: > + $(CLEAN) If might be easier to do something like: ifneq($(NO_CLEAN),y) clean: $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) endif David
[toc] | [prev] | [next] | [standalone]
| From | Shuah Khan <shuah@kernel.org> |
|---|---|
| Date | 2017-04-24 21:50 +0200 |
| Subject | Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean |
| Message-ID | <tzS9H-2HD-3@gated-at.bofh.it> |
| In reply to | #1629693 |
On 04/24/2017 09:45 AM, David Laight wrote: > From: Shuah Khan >> Sent: 22 April 2017 00:15 >> Define CLEAN macro to allow Makefiles to override common clean target >> in lib.mk. This will help fix the following failures: >> >> warning: overriding recipe for target 'clean' >> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> --- >> tools/testing/selftests/lib.mk | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index 775c589..959273c 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -51,8 +51,12 @@ endef >> emit_tests: >> $(EMIT_TESTS) >> >> -clean: >> +define CLEAN >> $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) >> +endef >> + >> +clean: >> + $(CLEAN) > > If might be easier to do something like: > > ifneq($(NO_CLEAN),y) > clean: > $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) > endif > > David > I am not sure that it is easier. Defining a macro would work well in this case to override and also works well with what we are doing for other overrides we already have such as EMIT_TESTS. thanks, -- Shuah
[toc] | [prev] | [next] | [standalone]
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2017-04-22 01:20 +0200 |
| Subject | [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings |
| Message-ID | <tyQ0i-3xb-29@gated-at.bofh.it> |
| In reply to | #1628668 |
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:44: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/x86/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile index 38e0a9c..4d27550 100644 --- a/tools/testing/selftests/x86/Makefile +++ b/tools/testing/selftests/x86/Makefile @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) all_64: $(BINARIES_64) -clean: +override define CLEAN $(RM) $(BINARIES_32) $(BINARIES_64) +endef $(BINARIES_32): $(OUTPUT)/%_32: %.c $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl -lm -- 2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2017-04-22 07:50 +0200 |
| Subject | Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings |
| Message-ID | <tyW5H-7iV-1@gated-at.bofh.it> |
| In reply to | #1628677 |
Shuah Khan <shuahkh@osg.samsung.com> writes: > Add override for lib.mk clean to fix the following warnings from clean > target run. > > Makefile:44: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > tools/testing/selftests/x86/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > index 38e0a9c..4d27550 100644 > --- a/tools/testing/selftests/x86/Makefile > +++ b/tools/testing/selftests/x86/Makefile > @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) > > all_64: $(BINARIES_64) > > -clean: > +override define CLEAN > $(RM) $(BINARIES_32) $(BINARIES_64) > +endef Simpler as: EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) cheers
[toc] | [prev] | [next] | [standalone]
| From | David Laight <David.Laight@ACULAB.COM> |
|---|---|
| Date | 2017-04-24 18:00 +0200 |
| Subject | RE: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings |
| Message-ID | <tzOz9-q9-37@gated-at.bofh.it> |
| In reply to | #1628781 |
From: Linuxppc-dev Michael Ellerman > Shuah Khan <shuahkh@osg.samsung.com> writes: > > > Add override for lib.mk clean to fix the following warnings from clean > > target run. > > > > Makefile:44: warning: overriding recipe for target 'clean' > > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > > --- > > tools/testing/selftests/x86/Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > > index 38e0a9c..4d27550 100644 > > --- a/tools/testing/selftests/x86/Makefile > > +++ b/tools/testing/selftests/x86/Makefile > > @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) > > > > all_64: $(BINARIES_64) > > > > -clean: > > +override define CLEAN > > $(RM) $(BINARIES_32) $(BINARIES_64) > > +endef > > Simpler as: > > EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) Actually for builds that insist on crapping all over the source tree I've used: clean: rm -rf `cat .cvsignore 2>/dev/null` David
[toc] | [prev] | [next] | [standalone]
| From | Shuah Khan <shuah@kernel.org> |
|---|---|
| Date | 2017-04-24 21:50 +0200 |
| Subject | Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings |
| Message-ID | <tzS9H-2HD-11@gated-at.bofh.it> |
| In reply to | #1629710 |
On 04/24/2017 09:57 AM, David Laight wrote: > From: Linuxppc-dev Michael Ellerman >> Shuah Khan <shuahkh@osg.samsung.com> writes: >> >>> Add override for lib.mk clean to fix the following warnings from clean >>> target run. >>> >>> Makefile:44: warning: overriding recipe for target 'clean' >>> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >>> >>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >>> --- >>> tools/testing/selftests/x86/Makefile | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >>> index 38e0a9c..4d27550 100644 >>> --- a/tools/testing/selftests/x86/Makefile >>> +++ b/tools/testing/selftests/x86/Makefile >>> @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) >>> >>> all_64: $(BINARIES_64) >>> >>> -clean: >>> +override define CLEAN >>> $(RM) $(BINARIES_32) $(BINARIES_64) >>> +endef >> >> Simpler as: >> >> EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) > > Actually for builds that insist on crapping all over the source tree I've used: > > clean: > rm -rf `cat .cvsignore 2>/dev/null` > > David This will have to be done as a separate change. The warnings I am fixing are related to common clean target in lib.mk and the need to override. thanks, -- Shuah
[toc] | [prev] | [next] | [standalone]
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2017-04-22 01:20 +0200 |
| Subject | [PATCH 5/8] selftests: powerpc: override clean in lib.mk to fix warnings |
| Message-ID | <tyQ0i-3xb-31@gated-at.bofh.it> |
| In reply to | #1628668 |
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:63: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/powerpc/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/powerpc/Makefile b/tools/testing/selftests/powerpc/Makefile index 1c5d057..8d9fc64 100644 --- a/tools/testing/selftests/powerpc/Makefile +++ b/tools/testing/selftests/powerpc/Makefile @@ -59,12 +59,13 @@ override define EMIT_TESTS done; endef -clean: +override define CLEAN @for TARGET in $(SUB_DIRS); do \ BUILD_TARGET=$$OUTPUT/$$TARGET; \ $(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET clean; \ done; rm -f tags +endef tags: find . -name '*.c' -o -name '*.h' | xargs ctags -- 2.9.3
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web