Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1629913
| From | Shuah Khan <shuah@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean |
| Date | 2017-04-24 21:50 +0200 |
| Message-ID | <tzS9H-2HD-3@gated-at.bofh.it> (permalink) |
| References | <tyQ0h-3xb-3@gated-at.bofh.it> <tyQ0i-3xb-23@gated-at.bofh.it> <tzOpt-mK-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/24/2017 09:45 AM, David Laight wrote: > From: Shuah Khan >> Sent: 22 April 2017 00:15 >> Define CLEAN macro to allow Makefiles to override common clean target >> in lib.mk. This will help fix the following failures: >> >> warning: overriding recipe for target 'clean' >> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> --- >> tools/testing/selftests/lib.mk | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index 775c589..959273c 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -51,8 +51,12 @@ endef >> emit_tests: >> $(EMIT_TESTS) >> >> -clean: >> +define CLEAN >> $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) >> +endef >> + >> +clean: >> + $(CLEAN) > > If might be easier to do something like: > > ifneq($(NO_CLEAN),y) > clean: > $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) > endif > > David > I am not sure that it is easier. Defining a macro would work well in this case to override and also works well with what we are doing for other overrides we already have such as EMIT_TESTS. thanks, -- Shuah
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/8] Fix clean target warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
[PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 17:10 +0200
[PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
Re: [PATCH 4/8] selftests: gpio: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 17:10 +0200
[PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:40 +0200
Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 15:40 +0200
Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Michael Ellerman <mpe@ellerman.id.au> - 2017-04-26 13:00 +0200
RE: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean David Laight <David.Laight@ACULAB.COM> - 2017-04-24 17:50 +0200
Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Shuah Khan <shuah@kernel.org> - 2017-04-24 21:50 +0200
[PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Michael Ellerman <mpe@ellerman.id.au> - 2017-04-22 07:50 +0200
RE: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings David Laight <David.Laight@ACULAB.COM> - 2017-04-24 18:00 +0200
Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Shuah Khan <shuah@kernel.org> - 2017-04-24 21:50 +0200
Re: [PATCH 8/8] selftests: x86: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 17:10 +0200
[PATCH 5/8] selftests: powerpc: override clean in lib.mk to fix warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-22 01:20 +0200
Re: [PATCH 0/8] Fix clean target warnings Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-28 00:10 +0200
csiph-web