Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1628009 > unrolled thread

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

Started byChandra Annamaneni <chandra627@gmail.com>
First post2017-04-21 09:50 +0200
Last post2017-04-21 12:40 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Chandra Annamaneni <chandra627@gmail.com> - 2017-04-21 09:50 +0200
    Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Greg KH <greg@kroah.com> - 2017-04-21 10:50 +0200
      Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Chandra Annamaneni <chandra627@gmail.com> - 2017-04-21 20:20 +0200
        Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Greg KH <greg@kroah.com> - 2017-04-21 20:30 +0200
    Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Joe Perches <joe@perches.com> - 2017-04-21 12:40 +0200

#1628009 — Re: [PATCH v3] Staging: most: use __func__ instead of the function name

FromChandra Annamaneni <chandra627@gmail.com>
Date2017-04-21 09:50 +0200
SubjectRe: [PATCH v3] Staging: most: use __func__ instead of the function name
Message-ID<tyBui-35R-3@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Third Reminder. Please review.

--
Chandra


On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:

> 
> Second reminder, please review.
> 
> Thanks.
> Chandra
> 
> 
> On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com>
> wrote:
> 
>       Change video.c to use %s, __func__ instead of function names.
>       Warnings flagged by checkpatch.pl
> 
>       Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
> 
>       diff --git a/drivers/staging/most/aim-v4l2/video.c
>       b/drivers/staging/most/aim-v4l2/video.c
>       index e074841..59e861e 100644
>       --- a/drivers/staging/most/aim-v4l2/video.c
>       +++ b/drivers/staging/most/aim-v4l2/video.c
>       @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
>               struct most_video_dev *mdev = video_drvdata(filp);
>               struct aim_fh *fh;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               switch (vdev->vfl_type) {
>               case VFL_TYPE_GRABBER:
>       @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
>               struct most_video_dev *mdev = fh->mdev;
>               struct mbo *mbo, *tmp;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               /*
>                * We need to put MBOs back before we call
>       most_stop_channel()
>       @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file,
>       void *priv, v4l2_std_id *norm)
>               struct aim_fh *fh = priv;
>               struct most_video_dev *mdev = fh->mdev;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               *norm = V4L2_STD_UNKNOWN;
>               return 0;
>       @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file,
>       void *priv, unsigned int index)
>               struct aim_fh *fh = priv;
>               struct most_video_dev *mdev = fh->mdev;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n",
>       index);
>       +       v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
> 
>               if (index >= V4L2_AIM_MAX_INPUT)
>                       return -EINVAL;
>       @@ -441,7 +441,7 @@ static int aim_register_videodev(struct
>       most_video_dev *mdev)
>        {
>               int ret;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               init_waitqueue_head(&mdev->wait_data);
> 
>       @@ -471,7 +471,7 @@ static int aim_register_videodev(struct
>       most_video_dev *mdev)
> 
>        static void aim_unregister_videodev(struct most_video_dev
>       *mdev)
>        {
>       -       v4l2_info(&mdev->v4l2_dev,
>       "aim_unregister_videodev()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               video_unregister_device(mdev->vdev);
>        }
> 
> 
> 
>

[toc] | [next] | [standalone]

#1628057

FromGreg KH <greg@kroah.com>
Date2017-04-21 10:50 +0200
Message-ID<tyCql-3El-9@gated-at.bofh.it>
In reply to#1628009
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Fri, Apr 21, 2017 at 12:40:25AM -0700, Chandra Annamaneni wrote:
> 
> Third Reminder. Please review.

2 days after you asked before?

And I don't even see this patch in my queue, are you sure it hasn't
already been handled, or merged, or rejected?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1628418

FromChandra Annamaneni <chandra627@gmail.com>
Date2017-04-21 20:20 +0200
Message-ID<tyLjY-Fc-39@gated-at.bofh.it>
In reply to#1628057
Sorry about the top posting.

I did ask about it on the 9th of April and the reply was that the email
was 'acked'. Since I did not get a further email, I assumed it was lost.
Perhaps I misunderstood.

Thanks!
Chandra


On Fri, 21 Apr 2017, Greg KH wrote:

> 
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Fri, Apr 21, 2017 at 12:40:25AM -0700, Chandra Annamaneni wrote:
> > 
> > Third Reminder. Please review.
> 
> 2 days after you asked before?
> 
> And I don't even see this patch in my queue, are you sure it hasn't
> already been handled, or merged, or rejected?
> 
> thanks,
> 
> greg k-h
>

[toc] | [prev] | [next] | [standalone]

#1628433

FromGreg KH <greg@kroah.com>
Date2017-04-21 20:30 +0200
Message-ID<tyLtE-Ix-23@gated-at.bofh.it>
In reply to#1628418
On Fri, Apr 21, 2017 at 11:06:54AM -0700, Chandra Annamaneni wrote:
> 
> Sorry about the top posting.
> 
> I did ask about it on the 9th of April and the reply was that the email
> was 'acked'. Since I did not get a further email, I assumed it was lost.
> Perhaps I misunderstood.

I really do not know, sorry.  If you didn't get an automated email from
my system that it was applied, rebased it against the latest
staging-next branch and resend it.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1628121

FromJoe Perches <joe@perches.com>
Date2017-04-21 12:40 +0200
Message-ID<tyE8O-4Ha-25@gated-at.bofh.it>
In reply to#1628009
On Fri, 2017-04-21 at 00:40 -0700, Chandra Annamaneni wrote:
> Third Reminder. Please review.

Patience.

> On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:
> > Second reminder, please review.
[]
> > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com>
> > wrote:
> > 
> >       Change video.c to use %s, __func__ instead of function names.
> >       Warnings flagged by checkpatch.pl
[]
> >       diff --git a/drivers/staging/most/aim-v4l2/video.c
[]
> >       @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
> >               struct most_video_dev *mdev = video_drvdata(filp);
> >               struct aim_fh *fh;
> > 
> >       -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> >       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

More likely all of these should be deleted
as these seem to be function tracing logging
and ftrace works well.

see: Documentation/trace/ftrace.txt

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web