Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1626718 > unrolled thread

Re: [PATCH] i2c: designware-baytrail: fix potential null pointer dereference on dev

Started byWolfram Sang <wsa@the-dreams.de>
First post2017-04-19 21:10 +0200
Last post2017-04-19 21:10 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] i2c: designware-baytrail: fix potential null pointer  dereference on dev Wolfram Sang <wsa@the-dreams.de> - 2017-04-19 21:10 +0200

#1626718 — Re: [PATCH] i2c: designware-baytrail: fix potential null pointer dereference on dev

FromWolfram Sang <wsa@the-dreams.de>
Date2017-04-19 21:10 +0200
SubjectRe: [PATCH] i2c: designware-baytrail: fix potential null pointer dereference on dev
Message-ID<ty39g-7fq-17@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Mon, Mar 20, 2017 at 11:51:23AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment to addr requires a call to get_sem_addr that dereferences
> dev, however, this dereference occurs before a null pointer check on dev.
> Move this assignment after the null check on dev to avoid a potential null
> pointer dereference.
> 
> Detected by CoverityScan, CID#1419700 ("Dereference before null check")
> 
> Fixes: fd476fa22a1f432 ("i2c: designware-baytrail: Add support for cherrytrail")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to for-next, thanks!

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web