Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1626718

Re: [PATCH] i2c: designware-baytrail: fix potential null pointer dereference on dev

From Wolfram Sang <wsa@the-dreams.de>
Newsgroups linux.kernel
Subject Re: [PATCH] i2c: designware-baytrail: fix potential null pointer dereference on dev
Date 2017-04-19 21:10 +0200
Message-ID <ty39g-7fq-17@gated-at.bofh.it> (permalink)
References <tn48G-4dt-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, Mar 20, 2017 at 11:51:23AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment to addr requires a call to get_sem_addr that dereferences
> dev, however, this dereference occurs before a null pointer check on dev.
> Move this assignment after the null check on dev to avoid a potential null
> pointer dereference.
> 
> Detected by CoverityScan, CID#1419700 ("Dereference before null check")
> 
> Fixes: fd476fa22a1f432 ("i2c: designware-baytrail: Add support for cherrytrail")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to for-next, thanks!

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] i2c: designware-baytrail: fix potential null pointer  dereference on dev Wolfram Sang <wsa@the-dreams.de> - 2017-04-19 21:10 +0200

csiph-web